Silence warnings to make our exceptions takeover

mallardduck · Mar 3, 2020 · 24d969b · 24d969b
1 parent 8abb4eb
commit 24d969b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/SocketClient.php b/src/SocketClient.php
@@ -28,12 +28,12 @@ public function __construct(string $socketUri, int $timeout = 30)
 
     public function connect(): self
     {
-        $fp = stream_socket_client($this->socketUri, $errno, $errstr, $this->timeout);
+        $fp = @stream_socket_client($this->socketUri, $errno, $errstr, $this->timeout);
         if (!is_resource($fp) && false === $fp) {
-            $message = sprintf("Stream Connection Failed: %s", $errstr);
+            $message = sprintf("Stream Connection Failed: %s unable to connect to %s", $errstr, $this->socketUri);
             throw new SocketClientException($message, $errno);
         }
-
+        
         $this->socket = $fp;
         $this->connected = true;
         return $this;

diff --git a/tests/WhoisSocketClientTest.php b/tests/WhoisSocketClientTest.php
@@ -26,6 +26,18 @@ public function testIsThereAnySyntaxError()
         unset($var);
     }
 
+    /**
+     * Basic test to check client syntax.
+     */
+    public function testIntentionalSyntaxError()
+    {
+        $var = new SocketClient("ztcpz://127.0.0.1:43", 10);
+        $this->assertIsObject($var);
+        $this->expectException(SocketClientException::class);
+        $var->connect();
+        unset($var);
+    }
+
     /**
      * Basic test to check client syntax.
      */