Add Angers Loire metropole service provider #3650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase limit to get better date
Limit to 100 instead of 150
5ila5
reviewed
Feb 4, 2025
doc/source/data_angers_fr.md
Outdated
Comment on lines
8
to
38
| - LES PONTS DE CE | ||
| - SAINT BARTHELEMY D ANJOU | ||
| - SAINT CLEMENT DE LA PLACE | ||
| - SAINTE GEMMES SUR LOIRE | ||
| - SAINT LAMBERT LA POTHERIE | ||
| - SAINT LEGER DE LINIERES | ||
| - SAINT-LEGER-DES-BOIS | ||
| - SAINT MARTIN DU FOUILLOUX | ||
| - LOIRE AUTHION | ||
| - VERRIERES EN ANJOU | ||
| - SARRIGNE | ||
| - SAVENNIERES | ||
| - SOULAINES SUR AUBANCE | ||
| - SOULAIRE ET BOURG | ||
| - TRELAZE | ||
| - RIVES DU LOIR EN ANJOU | ||
| - ANGERS | ||
| - AVRILLE | ||
| - BEAUCOUZE | ||
| - BEHUARD | ||
| - BOUCHEMAINE | ||
| - BRIOLLAY | ||
| - CANTENAY EPINARD | ||
| - ECOUFLANT | ||
| - ECUILLE | ||
| - FENEU | ||
| - LONGUENEE EN ANJOU | ||
| - MONTREUIL JUIGNE | ||
| - MURS ERIGNE | ||
| - PELLOUAILLES LES VIGNES | ||
| - LE PLESSIS GRAMMOIRE |
There was a problem hiding this comment.
Indent needs to be removed to be displayed nicely
5ila5
reviewed
Feb 4, 2025
Comment on lines
225
to
227
| typevoie: TYPE_VOIE | None = None, | ||
| address: str | None = None, | ||
| city: CITY | None = None, |
There was a problem hiding this comment.
You marked them as optional but your fetch/_get_idsecteur_address methods require them to be set.
There was a problem hiding this comment.
Thanks for review, yes i change it.
5ila5
reviewed
Feb 4, 2025
Comment on lines
233
to
238
| def _get_idsecteur_address(self, address: str, city: str, typevoie: str) -> dict: | ||
| url = self.api_secteur.format( | ||
| city=urllib.parse.quote(self.city.upper()), | ||
| address=urllib.parse.quote(self.address), | ||
| typevoie=urllib.parse.quote(self.typevoie.upper()), | ||
| ) |
There was a problem hiding this comment.
you pass arguments but use the attributes but not the arguments
There was a problem hiding this comment.
Thansk for review, i think it's ok.
5ila5
reviewed
Feb 4, 2025
| self.city = city | ||
| self.typevoie = typevoie | ||
|
|
||
| def _get_idsecteur_address(self, address: str, city: str, typevoie: str) -> dict: |
There was a problem hiding this comment.
your type hint says dict but you return list[dict]
There was a problem hiding this comment.
Thanks for review, i think it's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New source : Angers Loire Metropole
For 30 Cities Around Angers FRANCE.
All api call are using "open data Angers".
There is a "test " inside and all is running great !