Code formatting #1769
Open
Code formatting #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
force-pushed
the
code-formatting
branch
4 times, most recently
from
7af65df
to
3a033b3
Compare
poodlewars
force-pushed
the
code-formatting
branch
from
3a033b3
to
d85c3aa
Compare
as the order is semantically important
vasil-pashov
approved these changes
Aug 16, 2024
alexowens90
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce code formatting with Black and clang-format. See the
linting.mdfile I added indocs/for notes on usage and changes from the default settings.No changes to default Black formatting.
clang-format file is generated from
This PR doesn't actually reformat the codebase yet, except on a couple of example files. I'll do that as a last step once we're happy with the approach. This PR shows the effect though #1822 . Its CI shows that the linting checks pass after the reformatting.
d85c3aa shows the effect of the reformatting on a couple of files.