Use reference_proxy for primitive_layout

Signed-off-by: Julien Jerphanion <[email protected]>
man-group · Mar 18, 2024 · c974226 · c974226
1 parent c4f34cd
commit c974226
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/include/sparrow/layout.hpp b/include/sparrow/layout.hpp
@@ -94,9 +94,10 @@ namespace sparrow
     public:
 
         using self_type = primitive_layout<T>;
-        using value_type = T;
-        using reference = T&;
-        using const_reference = const T&;
+        using inner_value_type = T;
+        using value_type = std::optional<T>;
+        using reference = reference_proxy<self_type>;
+        using const_reference = const_reference_proxy<self_type>;
         using pointer = T*;
         using const_pointer = const T*;
         using size_type = std::size_t;
@@ -108,8 +109,8 @@ namespace sparrow
         using const_iterator = primitive_layout_iterator<T, true>;
 
         size_type size() const;
-        reference element(size_type i);
-        const_reference element(size_type i) const;
+        reference value(size_type i);
+        const_reference value(size_type i) const;
 
         iterator begin();
         iterator end();
@@ -203,17 +204,17 @@ namespace sparrow
     }
 
     template <class T>
-    auto primitive_layout<T>::element(size_type i) -> reference
+    auto primitive_layout<T>::value(size_type i) -> reference
     {
         assert(i < size());
-        return i[data()];
+        return reference(*this, i);
     }
 
     template <class T>
-    auto primitive_layout<T>::element(size_type i) const -> const_reference
+    auto primitive_layout<T>::value(size_type i) const -> const_reference
     {
         assert(i < size());
-        return i[data()];
+        return const_reference(*this, i);
     }
 
     template <class T>

diff --git a/test/test_layout.cpp b/test/test_layout.cpp
@@ -73,8 +73,8 @@ namespace sparrow
             auto citer = lt.cbegin();
             for (std::size_t i = 0; i < lt.size(); ++i)
             {
-                CHECK_EQ(*iter++, lt.element(i));
-                CHECK_EQ(*citer++, lt.element(i));
+                CHECK_EQ(*iter++, lt.value(i));
+                CHECK_EQ(*citer++, lt.value(i));
             }
             CHECK_EQ(iter, lt.end());
             CHECK_EQ(citer, lt.cend());