Added implementation of buffer #1
Conversation
JohanMabille
force-pushed
the
buffer
branch
3 times, most recently
from
4d08bd0
to
880225c
Compare
| bool empty() const noexcept; | ||
| size_type size() const noexcept; | ||
|
|
||
| template <class U = T> |
There was a problem hiding this comment.
Why do we need to allow conversion of the stored element type?
There was a problem hiding this comment.
Because we may need to have some buffer of "raw" memory (i.e. uint8_t) that we need to reinterpret as another type.
There was a problem hiding this comment.
Se my comment in the implementation.
| using size_type = typename base_type::size_type; | ||
|
|
||
| xbuffer() = default; | ||
| explicit xbuffer(size_type size); |
There was a problem hiding this comment.
For the non-defaulted constructors, consider checking if noexcept is usable.
BTW I suspect this type could be constexpr (and could be tested at compile-time too) but maybe lets consider that in another pass.
There was a problem hiding this comment.
This constructors allocates memory, so I'm not sure we can use noexcept here.
There was a problem hiding this comment.
Depends on what's used for allocation exactly, for example std::vector can be instantiated in constexpr context in c++20. But otherwise o lets noexcept where it makes sense. My main worry is copy and move operations as they have an impact on the performance when stored in a vector.
| ~xbuffer(); | ||
|
|
||
| xbuffer(const xbuffer&); | ||
| xbuffer& operator=(const xbuffer&); |
There was a problem hiding this comment.
same points as previously with assignations
JohanMabille
force-pushed
the
buffer
branch
2 times, most recently
from
1efe73b
to
33ac91b
Compare
| const std::size_t size = 4; | ||
| buffer_test_type b1(make_test_buffer(size), size); | ||
| buffer_test_type b2(make_test_buffer(size), size); | ||
| CHECK(b1 == b2); |
No description provided.