Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround for clang/apple/libc++ #126

Merged
merged 4 commits into from
Jul 1, 2024
Merged

workaround for clang/apple/libc++ #126

merged 4 commits into from
Jul 1, 2024

Conversation

DerThorsten
Copy link
Collaborator

@DerThorsten DerThorsten commented Jul 1, 2024 •
edited
Loading

I see the same issue as mentioned in #108

This crude workaround/hack allows me to compile on mac with clang

@DerThorsten DerThorsten marked this pull request as ready for review July 1, 2024 08:50
Klaim
Klaim approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽 in particular if it works with #114

@SylvainCorlay SylvainCorlay merged commit 40c8c6b into man-group:main Jul 1, 2024
31 checks passed
@SylvainCorlay SylvainCorlay mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan left review comments

@Klaim Klaim Klaim approved these changes

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DerThorsten @Klaim @SylvainCorlay @JohanMabille @jjerphan