Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move arrow_array arrow_schema and arrow_array_schema_proxy implem to … #239

Conversation

Alex-PLACET
Copy link
Collaborator

@Alex-PLACET Alex-PLACET commented Oct 16, 2024

…cpp files

To fix issues with the release_arrow_schema and release_arrow_array adresses.
The code is copy pasted + SPARROW_API and some includes. There is no modification in the impl

…cpp files

To fix issues with the release_arrow_schema and release_arrow_array adresses
@@ -282,21 +283,21 @@ TEST_SUITE("C Data Interface")
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from this point it's only formatting

@Alex-PLACET Alex-PLACET marked this pull request as ready for review October 16, 2024 09:38
@Alex-PLACET Alex-PLACET merged commit bd1d621 into man-group:main Oct 16, 2024
55 checks passed
@Alex-PLACET Alex-PLACET deleted the move_impl_arrow_array_schema_and_proxy_to_cpp branch October 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants