Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dictionary encoded layout #56

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add dictionary encoded layout #56

merged 1 commit into from
Apr 4, 2024

Conversation

Alex-PLACET
Copy link
Collaborator

@Alex-PLACET Alex-PLACET commented Apr 3, 2024 •
edited
Loading

Fix #40

@Alex-PLACET Alex-PLACET self-assigned this Apr 3, 2024
@Alex-PLACET Alex-PLACET marked this pull request as ready for review April 3, 2024 09:27
JohanMabille
JohanMabille reviewed Apr 3, 2024
View reviewed changes
include/sparrow/array_data.hpp Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/mp_utils.hpp Outdated Show resolved Hide resolved
jjerphan
jjerphan approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I just have few minors comments and questions.

include/sparrow/dictionary_encoded_layout.hpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Show resolved Hide resolved
test/test_dictionary_encoded_layout.cpp Outdated Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Show resolved Hide resolved
include/sparrow/dictionary_encoded_layout.hpp Show resolved Hide resolved
@Alex-PLACET Alex-PLACET force-pushed the add_dictionary_encoded_layout branch from 9a6ab2b to 06e2357 Compare April 4, 2024 09:56
@Alex-PLACET Alex-PLACET force-pushed the add_dictionary_encoded_layout branch from 06e2357 to 6e20750 Compare April 4, 2024 10:01
@Alex-PLACET Alex-PLACET merged commit dbbfd27 into man-group:main Apr 4, 2024
20 checks passed
@Alex-PLACET Alex-PLACET deleted the add_dictionary_encoded_layout branch April 4, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim left review comments

@JohanMabille JohanMabille JohanMabille approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees

@Alex-PLACET Alex-PLACET

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement dictionary_encoded_layout
4 participants
@Alex-PLACET @Klaim @JohanMabille @jjerphan