Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample project with cocoapods #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marciomeschini
Copy link

• fix sample project - it now uses FTGooglePlacesAPI as pod
• fix tests

@marciomeschini marciomeschini changed the title Marco/development Fix sample project with cocoapods Aug 28, 2014
@lukaskukacka
Copy link
Contributor

Hello Marcio,
thanks for your contribution. What exactly is the contribution of the pull request compared to current master version please?

From what I understand from commits and testing this code:

  • It is creating new project for examples and just copying source codes from already existing example app
  • Making the original example project not work, the project cannot even be opened
  • Making a lot of unnecessary changes (git changes) in project files

Only added value seems to be added support for Cocoa pods to example project, but I believe its not worth the troubles in this case

@marciomeschini
Copy link
Author

Hello Lukas,

you are right. This PR addresses only a better support to cocoapods. My thought was:
• before do any changes maybe it could be worth to fix the current workspace (since when you download it it does not match the usual cocoapods standards)
• the original project still works, you need to run pod install (see http://guides.cocoapods.org/making/using-pod-lib-create). We can include Podfile.lock and Pods if you want to save the user from doing this

Last bit, only to give you a better picture, about other changes I made so far and I have not included in the PR:
• return a reference to the AFHTTPRequestOperation (then we can cancel them, for instance)
• extension that returns "open now" and "opening hours" from a detail response

Many thanks for your time and thank you for your very nice library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants