Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change method of removing trailing slash from url to support ios… #156

Conversation

olliescase
Copy link
Contributor

… <17

Addresses #155

@olliescase
Copy link
Contributor Author

Here's some testing I did of the function, trying to make sure I kept the same behaviour as the original regex.

image

If its just a / then it returns the original string. (/)
If its anything else that ends with a /, then it removes the last character (the /)
If it doesn't end in a /, then it returns the original string.

@manchenkoff
Copy link
Owner

Hey @olliescase, thanks a lot for the contribution! There is a slight formatting issue, please run pnpm lint:fix locally and run package check before committing the changes via pnpm validate.

@manchenkoff
Copy link
Owner

Closes #155

@manchenkoff manchenkoff merged commit e0d5275 into manchenkoff:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants