Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keepRequestedRoute #16

Merged
merged 2 commits into from
Dec 31, 2023
Merged

fix: keepRequestedRoute #16

merged 2 commits into from
Dec 31, 2023

Conversation

putrafajarh
Copy link
Contributor

this commit fix, when set redirect.keepRequestedRoute = true but still redirecting to config redirect.onLogin

@manchenkoff manchenkoff self-requested a review December 27, 2023 11:26
@manchenkoff manchenkoff self-assigned this Dec 27, 2023
manchenkoff
manchenkoff requested changes Dec 27, 2023
View reviewed changes
Copy link
Owner

@manchenkoff manchenkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @putrafajarh, thanks a lot for the contribution! Left one minor comment, pls take a look when you have time, besides that LGTM 👍

src/runtime/composables/useSanctumAuth.ts Outdated Show resolved Hide resolved
@manchenkoff manchenkoff merged commit 9c240dd into manchenkoff:main Dec 31, 2023
1 check passed
@manchenkoff
Copy link
Owner

Thanks @putrafajarh for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manchenkoff manchenkoff manchenkoff approved these changes

Assignees

@putrafajarh putrafajarh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@putrafajarh @manchenkoff