Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent multiple identity requests on init #77

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

manchenkoff
Copy link
Owner

@manchenkoff manchenkoff commented Apr 17, 2024

Is your PR related to a specific issue/feature? Please describe and mention issues.

Partially fixes #69, the plugin initialization method was changed in favor of passing the state of the user identity request from the server to the client to prevent another attempt to load the user when we receive 401 on the SSR side.

Also, we reset the plugin user state only when we receive 401 for user retrieval operation and not for other endpoints.

Checklist:

  • Code style and linters are passing
  • Backwards compatibility is maintained
  • Requires documentation to be updated

@manchenkoff manchenkoff added the enhancement New feature or request label Apr 17, 2024
@manchenkoff manchenkoff self-assigned this Apr 17, 2024
@manchenkoff manchenkoff linked an issue Apr 17, 2024 that may be closed by this pull request
@manchenkoff manchenkoff merged commit 36c6b13 into main Apr 17, 2024
1 check passed
@manchenkoff manchenkoff deleted the 69-user-is-requested-on-every-page branch April 17, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User is requested on every page
1 participant