Improve browser stealer & add SQLite lib detection #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
approved these changes
May 11, 2023
Still34
added a commit
to Still34/capa-testfiles
that referenced
this pull request
May 12, 2023
Signed-off-by: Still Hsu <[email protected]>
mr-tz
requested changes
May 12, 2023
collection/browser/gather-chrome-based-browser-login-information.yml
Outdated
Show resolved
Hide resolved
|
from the linter: |
|
Ah right, oops, accidentally used substring instead of string. |
|
Now, we get this from the linter: |
|
Sorry for the stale PR - it looks like the linter passes the test locally for me though. |
|
It doesn't match for me. The function doesn't contain the SELECT strings. Can you double check what's off? |
- Fix erroneous regex capture + Add detections for cookies gathering + Add generic browser detection (some webkit browser for some reason uses the same chromium-based paths?) Signed-off-by: Still Hsu <[email protected]>
- Typically used along with browser data collection Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Still34
force-pushed
the
patches/browser-stealer-improve
branch
from
da4afb4
to
4520523
Compare
|
After having a headache trying to figure out what went wrong for 30 minutes, finally figured out what was causing it to not match - it was due to the default scope the previous rule used, switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds detection for SQL statements related to cookie accesses, fixes one of the regexes, as well as adding rudimentary support for detection static sqlite3/cppsqlite3 lib linking. The relevant samples will be submitted to the test repo once I get the go ahead from the maintainers.