Update hash-data-using-fnv.yml #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-tz
reviewed
Jul 11, 2023
| @@ -33,3 +40,4 @@ rule: | |||
| - or: | |||
| - mnemonic: imul | |||
| - mnemonic: mul | |||
| - api: _allmul | |||
There was a problem hiding this comment.
should this be a function-name feature?
linter fails: FAIL: doesn't match on referenced example: Fix the rule logic or provide a different example
There was a problem hiding this comment.
@williballenthin _allmul is an api feature here and function-name is not valid in a basic block
are these two issues?
There was a problem hiding this comment.
function-name is for matching the name of the current function. i think api is correct here.
didn't match the old example, it's fixed
mr-tz
approved these changes
Jul 11, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.