Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create encrypt-data-using-rc4-via-systemfunction033.yml #890

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Create encrypt-data-using-rc4-via-systemfunction033.yml #890

merged 3 commits into from
Apr 22, 2024

Conversation

dstepanic
Copy link
Contributor

Hi,

This rule is pretty much a duplicate of the existing rule (SystemFunction032), it's paired with another undocumented API (SystemFunction033) that implements encryption/decryption using RC4 algorithm. Thanks!

References

Similar to SystemFunction032, this undocumented API allows encryption/decryption using RC4 algo
Copy link

google-cla bot commented Apr 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstepanic!

We should get the test file added too, though since it's shellcode I'm not sure it'll work in our test harness.

Are you able to sign the CLA? After I'd be happy to merge this PR.

@dstepanic
Copy link
Contributor Author

Thanks @williballenthin. Yes, I signed the CLA yesterday. Appreciate it.

mr-tz added a commit to mandiant/capa-testfiles that referenced this pull request Apr 19, 2024
@mr-tz
Copy link
Collaborator

mr-tz commented Apr 19, 2024

please rename per the lint info:

  • FAIL: filename doesn't match the rule name: Rename rule file to match the rule name, expected: "encryptdecrypt-data-using-rc4-via-systemfunction033.yml", found: "encrypt-data-using-rc4-via-systemfunction033.yml"

I've added the testfile to capa-testfiles.

@mr-tz
Copy link
Collaborator

mr-tz commented Apr 19, 2024

file and rule name still don't pass the linter

@mr-tz mr-tz merged commit c454ffb into mandiant:master Apr 22, 2024
3 checks passed
@mr-tz
Copy link
Collaborator

mr-tz commented Apr 22, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants