rule scoping tweaks #1714
Merged
rule scoping tweaks #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the primary operation is `contain()`, set is more appropriate than tuple.
make a local copy of the scopes dict
im worried this will interact poorly with our rule cache, unless we add more handling there, which needs more testing. so, since the filtering likely has only a small impact on performance, revert the rule filtering changes for simplicity.
williballenthin
added
enhancement
yelhamer
approved these changes
Aug 15, 2023
| @@ -1280,11 +1280,6 @@ def __init__( | |||
|
|
|||
| ensure_rule_dependencies_are_met(rules) | |||
|
|
|||
| if rules_filter_func: | |||
There was a problem hiding this comment.
The addition of ruleset filtering might be premature optimization in the mean time anyways. So I suggest we think about measuring the performance difference first before prioritizing updating the cache and adding this back in.
…into fix/issue-1697-1
williballenthin
merged commit c001c88
into
dynamic-feature-extraction
7 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review and merge #1713 first
This PR makes some minor tweaks to how the
Scopesobject is parsed, nothing notable, except maybe using a set instead of tuple, and avoiding modifying passed-in arguments.This PR also reverts the filtering of rules by the current analysis flavor. As I studied #1697, I noticed that this may influence the rule cache (which is already slightly brittle) which I think we should try to avoid. Rather than spend more time on understanding the interplay, I'd propose simplifying the code by reverting to the old rule set construction. This might have a small performance overhead, since we keep around rules that are not relevant to the current flavor, but its simple and obvious.
Checklist