Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Manga Plus from Shueisha. #7741

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rangicus
Copy link

@rangicus rangicus commented Feb 9, 2025

Fix was made a year ago by MikeZeDev, lints and runs fine.

@ronny1982
Copy link
Contributor

There were two competing pull requests, any reason why #7112 should be merged instead of #7175

@rangicus
Copy link
Author

rangicus commented Feb 9, 2025

I hadn't seen any competing pull requests, as those were both closed at the time of me checking. This was the one I ended up finding just because it was in a branch with an accurate title. I haven't tested the other one, but this is one is confirmed working where the master branch is not.

@ronny1982
Copy link
Contributor

Unfortunately the build pipeline is so outdated that there are no reliable test results anymore which poses a risk for any PRs.

@ronny1982
Copy link
Contributor

Suggestion to close PR after Sunday, 4 May 2025 (12 weeks) if not approved by a reviewer.

@MikeZeDev
Copy link
Contributor

Since this is copy-pasted from my own PR i dont think it would be a good thing for me to review it. Thats not how you ensure code quality and detect errors. 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants