Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ongoing] Improve Management of Bookmarks / Itemflags #304

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ronny1982
Copy link
Contributor

@ronny1982 ronny1982 commented Oct 29, 2023

Goal: Combined Import/Export for Bookmarks and Flags

  • Remove global singleton access of ItemflagManager from BookmarkPlugin
  • Revise the update for each entry in BookmarkPlugin
  • Revise interface and shrink code in ItemflagManager
  • Update tests and test cases
  • Adjust frontend

@Sheepux Sheepux requested a review from Copilot November 22, 2024 13:43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • web/src/frontend/classic/components/Media.svelte: Language not supported
  • web/src/frontend/classic/components/MediaItem.svelte: Language not supported
  • web/src/frontend/classic/components/MediaItemSelect.svelte: Language not supported
  • web/src/frontend/classic/components/Suggestions.svelte: Language not supported
  • web/src/frontend/classic/components/content-pages/Bookmarks.svelte: Language not supported
  • web/src/frontend/classic/components/viewer/Viewer.svelte: Language not supported
  • web/src/engine/providers/Bookmark.ts: Evaluated as low risk
  • web/src/engine/providers/BookmarkPlugin.ts: Evaluated as low risk
@ronny1982 ronny1982 removed the Engine label Dec 10, 2024
@Sheepux Sheepux added the Engine label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants