Cannot read from progmem array directly. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from an array entry. This fixes the problem that only pipe 0 and 1 could be opened (because child_pipe_enable[child] was always 0)
|
Aaah.. Thanks! I've been meaning to look into this problem. Will pull this as soon as I get a few free minutes to test it. |
|
Fixed in 2c97186. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing with RF24Network meshping example, I noticed that I could not use addresses which involves pipes 2-5. I dug into the NRF24L01+ datasheet and the RF24 library and found out that EN_RXADDR was always set to 0x03 (pipe 0 and 1, default) after initializing, no matter which pipe you tried to open for reading.
Then I looked at openReadingPipe() in RF24.cpp and noticed that
_BV(child_pipe_enable[child])always returned 1, no matter the value ofchild. I fixed the problem and now the RF24Network meshping example works for me (which fixes maniacbug/RF24Network#3, I guess).