Trading ban #2853
Trading ban #2853
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mantikoros if u think someone else should review let me know. Also, I might need help resolving the conflict as I think the conflict editor is being dumb (or I am) and I don't want to accidentally undo someone's changes. |
|
Oh, I just did a trading ban (rather than sweepcash and mana-specific), because I couldn't think of a single scenario where we'd want to ban someone from one and not just both. Admin accounts not being allowed to trade sweepcash is covered by other logic. |
|
I can think of several cases where we'd only want to ban sweeps trading but not mana trading: Being an admin account is an overly restrictive condition. Future Manifold employees will not be admins. Non-employees who are connected to Manifold may also need to be banned. Users may also voluntarily request to be banned from trading as part of our responsible gaming program. |
| @@ -14,15 +14,15 @@ const bodySchema = z | |||
| }) | |||
| .strict() | |||
|
|
|||
| export const banuser = authEndpoint(async (req, auth) => { | |||
| export const banUserFromPosting = authEndpoint(async (req, auth) => { | |||
| const { userId, unban } = validate(bodySchema, req.body) | |||
There was a problem hiding this comment.
best to name properties in the positive valence, like ban rather than unban
| userId, | ||
| }) | ||
| await updateUser(pg, userId, { | ||
| isBannedFromMana: !unban, |
There was a problem hiding this comment.
would prefer isBannedFromManaTrading
| userId, | ||
| }) | ||
| await updateUser(pg, userId, { | ||
| isBannedFromSweepcash: !unban, |
There was a problem hiding this comment.
isBannedFromSweeipcashTrading
| @@ -16,11 +16,15 @@ import { Answer } from 'common/answer' | |||
| import { CpmmState, getCpmmProbability } from 'common/calculate-cpmm' | |||
| import { ValidatedAPIParams } from 'common/api/schema' | |||
| import { onCreateBets } from 'api/on-create-bet' | |||
| <<<<<<< trading-ban | |||
There was a problem hiding this comment.
fix these merge errors
| @@ -307,11 +319,16 @@ export const fetchContractBetDataAndValidate = async ( | |||
| 'You must be kyc verified to trade on sweepstakes markets.' | |||
| ) | |||
| } | |||
| <<<<<<< trading-ban | |||
There was a problem hiding this comment.
more merge indicators to remove
| @@ -307,11 +319,16 @@ export const fetchContractBetDataAndValidate = async ( | |||
| 'You must be kyc verified to trade on sweepstakes markets.' | |||
| ) | |||
| } | |||
| <<<<<<< trading-ban | |||
| if (user.userDeleted) { | |||
| throw new APIError(403, 'You are banned or deleted.') | |||
| @@ -322,7 +339,12 @@ export const fetchContractBetDataAndValidate = async ( | |||
| log( | |||
| `Loaded user ${user.username} with id ${user.id} betting on slug ${contract.slug} with contract id: ${contract.id}.` | |||
| ) | |||
|
|
|||
| if (user.isBannedFromMana && contract.token !== 'CASH') { | |||
There was a problem hiding this comment.
might as well check for the mana token
| @@ -312,15 +312,29 @@ export const updateMarket = curriedAPI('market/:contractId/update') | |||
|
|
|||
| export const updateUser = curriedAPI('me/update') | |||
|
|
|||
| export function banUser(params: { userId: string; unban?: boolean }) { | |||
| return call(getApiUrl('ban-user'), 'POST', params) | |||
| export function banUserFromPosting(params: { | |||
There was a problem hiding this comment.
This isn't how we create api endpoints anymore, but I guess this is okay. In the future you should use the schema.ts
| db, | ||
| 'users', | ||
| ...defaultFields, | ||
| 'isBannedFromPosting', |
There was a problem hiding this comment.
just add these to the default fields, right?
No description provided.