Auto resolve sports markets #3342
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
IanPhilips
requested changes
Jan 10, 2025
There was a problem hiding this comment.
I don't see why you're calling the API from the scheduler. If you actually want the api endpoint for use by the front-end, you'd add the function to the backend/shared directory for the scheduler and api to call directly. If getting the completed sports games is a scheduler only task, just keep the logic in the scheduler. It would be nice to get the scores during the game on the frontend, though
IanPhilips
reviewed
Jan 10, 2025
IanPhilips
reviewed
Jan 10, 2025
IanPhilips
reviewed
Jan 10, 2025
IanPhilips
reviewed
Jan 15, 2025
IanPhilips
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't been able to test as I haven't been able to redeploy the scheduler to dev.
My first time coding something involving the scheduler so let me know if I'm doing something wrong!