Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade supports-color to same version as eslint #326

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mantoni
Copy link
Owner

@mantoni mantoni commented Oct 30, 2024

On node v23.1.0, invocations of eslint_d print this warning:

(node:21499) ExperimentalWarning: CommonJS module .../node_modules/debug/src/node.js is loading ES
Module .../node_modules/supports-color/index.js using require().                                          
Support for loading ES Module in require() is an experimental feature and might change at any time

The cause of this is that eslint_d has a direct dependency to supports-color@^9 which is ESM, while eslint depends on supports-color@^7 through chalk which is CJS.

This change downgrades supports-color to v7 to only have the CJS version installed. With this, the warning is not showing anymore.

@mantoni mantoni merged commit 5c8072a into main Oct 30, 2024
8 checks passed
@mantoni mantoni deleted the downgrade-supports-color branch October 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant