Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "OnPhysGunPull" output in CPhysicsProp #266

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rlenhub
Copy link

@rlenhub rlenhub commented Jan 1, 2024

The new output allows mappers to fire events when a physics prop is "pulled" by the gravity gun (secondary fire from afar).


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link
Collaborator

@arbabf arbabf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like pullDir isn't being used here at all, and could probably be removed.

@rlenhub
Copy link
Author

rlenhub commented Feb 26, 2024

made the requested change, pullDir was indeed not being used and I removed it

Copy link
Collaborator

@arbabf arbabf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants