Fix dynamic interactions using "their_" keyvalues always assuming separate sequence names #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update added support for interaction partners to use separate sequence names. This involves a new boolean value which is enabled if any separate sequence name keyvalues are parsed. However, there was an oversight in which this boolean value was enabled when any keyvalue starting with
their_is parsed, such astheir_healthfrac. This PR fixes that and only enables the boolean value when the activity or sequence keyvalues are used.This issue mainly causes problems for interactions which use activities instead of sequence names, as the activities will select different sequences between the two interaction participants.
PR Checklist
developbranch OR targets another branch with a specific goal in mind