This repository has been archived by the owner on May 9, 2018. It is now read-only.
* Fixed some retain cycles that were preventing the RMMapView from deallocating #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, just noticed these also. |
| }); | ||
| } | ||
|
|
||
| [_zoomDelegateQueue setSuspended:YES]; | ||
|
|
||
| if ([_zoomDelegateQueue operationCount] == 0) | ||
| if ([_zoomDelegateQueue operationCount] == 0 && _delegateHasAfterMapZoom) |
There was a problem hiding this comment.
These two changes related to checking the delegate before queueing the block have me concerned since they change the actual behavior order when trying to just get rid of a retain cycles. Will adapt.
incanus
added a commit
that referenced
this pull request
Mar 17, 2014
|
These fixes have been incorporated. |
|
Thanks a lot. |
dcacenabes
referenced
this pull request
in davididntt/mapbox-ios-sdk
Apr 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be quite a few memory leaks caused by retain cycles.
Outdooractive/route-me#102
#221
I have fixed a few of these with this commit. You can reproduce the leak easily by pushing a view controller with a RMMapView onto a Navigation Controller and popping it off again.