Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another alternative fix for #90 (ensure property key strings are serialized in correct order) #93

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

ivorblockley
Copy link
Contributor

Another alternative to pick from. This is the "keep it simple approach".

@ivorblockley
Copy link
Contributor Author

I suspect all three approaches will be similar in real-world performance, although it would be nice to have some speed benchmarks to test this. Otherwise the choice probably comes down to stylistic preference. #92 introduces an ES6 feature whereas this merge request along with #91 doesn't, which might also be a consideration.

@mourner
Copy link
Member

mourner commented Dec 10, 2017

#92 is cleaner code-wise, but browser support is a concern — e.g. as far as I know iterating over the map.keys() with a for of loop isn't supported in IE and Safari versions <10. This version is as simple and does the job without upping the requirements, so I'll go with that. Looking at the code, performance shouldn't be affected. Thanks a lot for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants