-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centering 38 maki icons #565
Conversation
I was thinking about 0.5px moved icons. |
@Udobnyj this is a little tedious, but could you share a map example with these icons using a background? Also perhaps a map example showing the before with backgrounds? Just to get a better sense of how centering these addresses visual inconsistency? |
Edit Oh! I missed your comment here #565 (comment) |
I decided to revert ten icons (6 of those that I moved by 0.5 pixels and four more). As I wrote above, I will correct them in this resizing task. Therefore, this push now has 38 changed icons (I forgot about charging-station.svg and added it). Below are links to specific ones. But it's too much of them to test it on the map. I think a better way will be to check others in my Figma file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
Based on this task, I adjusted 46 of our icons to work better with the background.
I didn't change the vector. I just moved them inside the artboards. But six of them are not along the pixel grid but 0.5px: shelter, bowling-alley, basketball, ferry-JP, amusement-park, and religious-muslim.
MAIN STUDIO TEST LINK
Concreete 0.5px icons links
I didn't find shelter, bowling-alley, and ferry-JP, so I replaced the other icons.
shelter
bowling-alley
ferry-JP
basketball
amusement-park
religious-muslim