change 34 icons #572
Merged
change 34 icons #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Udobnyj
force-pushed
the
size-consistency
branch
3 times, most recently
from
bae2559 to
2391c86
Compare
willymaps
reviewed
Jun 23, 2022
| <svg id="bowling-alley" xmlns="http://www.w3.org/2000/svg" width="15" height="15" viewBox="0 0 15 15"> | ||
| <path id="icon_concepts:_sports_leisure" d="M8.83,5.39a11.0127,11.0127,0,0,0-.96,4.28,11.4686,11.4686,0,0,0,.58,3.69A4.9424,4.9424,0,0,1,6,14,5,5,0,1,1,8.98,4.99C8.94,5.12,8.88,5.25,8.83,5.39ZM4.12,8.5a.62.62,0,1,0-.62.62h0a.6105.6105,0,0,0,.62-.6009C4.12,8.5128,4.12,8.5064,4.12,8.5ZM4.5,7.12a.62.62,0,1,0-.62-.62h0a.6106.6106,0,0,0,.6011.62ZM6.12,8.5a.62.62,0,1,0-.62.62h0a.6105.6105,0,0,0,.62-.6009C6.12,8.5128,6.12,8.5064,6.12,8.5Zm4.8022-5.3341c0-.7222-.1444-.7222-.1444-1.4444a.7222.7222,0,0,1,1.4444-.0007v.0007c0,.7222-.1444.7222-.1444,1.4444,0,2.1667,1.5528,3.6168,1.5528,6.5,0,2.1667-.6861,4.3333-1.4083,4.3333H10.7778c-.7222,0-1.4083-2.1667-1.4083-4.3333C9.3694,6.7826,10.9222,5.3325,10.9222,3.1659Z"/> | ||
| <svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" id="bowling-alley"> | ||
| <path d="M10.9222 3.16585C10.9222 2.80475 10.8861 2.6242 10.85 2.44365 10.8139 2.2631 10.7778 2.08255 10.7778 1.72145 10.7777 1.52991 10.8537 1.34618 10.9891 1.21068 11.1245 1.07517 11.3081.998995 11.4997.998901 11.6912.998809 11.8749 1.07481 12.0104 1.21018 12.1459 1.34555 12.2221 1.52921 12.2222 1.72075 12.2222 2.08185 12.1861 2.26258 12.15 2.4433 12.1139 2.62403 12.0778 2.80475 12.0778 3.16585 12.0778 4.17196 12.4126 5.02355 12.7713 5.93586 13.1851 6.98826 13.6306 8.12146 13.6306 9.66585 13.6306 11.8326 12.9445 13.9992 12.2223 13.9992H10.7778C10.0556 13.9992 9.36951 11.8325 9.36951 9.66585 9.36945 8.12135 9.815 6.98809 10.2288 5.93566 10.5874 5.0234 10.9222 4.17186 10.9222 3.16585ZM8.91959 6.57474C8.62376 7.4299 8.36947 8.43163 8.36951 9.66589 8.36951 10.7024 8.51281 11.7479 8.75007 12.6124 7.93094 13.4675 6.77765 14 5.5 14 3.01472 14 1 11.9853 1 9.5 1 7.01472 3.01472 5 5.5 5 6.86846 5 8.09426 5.61084 8.91959 6.57474ZM3.4735 8.40932C3.24509 8.45475 3.05636 8.64348 3.01093 8.87188 2.9396 9.2305 3.22719 9.57548 3.58836 9.57548 3.82033 9.57912 4.03738 9.43895 4.1295 9.22602 4.20836 9.04375 4.18824 8.82483 4.07787 8.65966 3.94849 8.46602 3.70191 8.36388 3.4735 8.40932ZM5.11536 6.97273C5.04404 6.61419 4.65037 6.40377 4.31263 6.54367 4.01809 6.66567 3.87287 7.01479 3.98989 7.31014 4.07867 7.53425 4.29863 7.67633 4.53793 7.67633 4.90349 7.67633 5.18667 7.33127 5.11536 6.97273ZM5.37265 8.40932C5.14424 8.45475 4.95552 8.64348 4.91008 8.87188 4.88737 8.98609 4.89903 9.10446 4.94359 9.21204 5.06558 9.50656 5.41468 9.65178 5.71003 9.53483 5.8516 9.47877 5.9682 9.36577 6.02866 9.22602 6.15229 8.94026 6.00503 8.56386 5.71281 8.44282 5.60523 8.39826 5.48686 8.3866 5.37265 8.40932Z"/> | ||
| </svg> |
There was a problem hiding this comment.
Should the finger hole circles continue to be as large as they are in the current design? They seem like important indicators. Also seeing some additional anchors around the finger holes.
There was a problem hiding this comment.
Thank you, I totally agree. I returned the old holes and deleted unnecessary anchors
willymaps
reviewed
Jun 23, 2022
| <path d="M13.536,12.008h0a1.584,1.584,0,0,0-1.105.416l-.437.407a.662.662,0,0,1-.928,0c-.139-.119-.269-.258-.409-.387a1.679,1.679,0,0,0-2.275,0c-.148.129-.288.278-.436.407a.663.663,0,0,1-.929,0c-.148-.129-.288-.278-.436-.407a1.68,1.68,0,0,0-2.266,0c-.139.129-.269.268-.408.387a.86.86,0,0,1-.279.159.748.748,0,0,1-.743-.248,5.9,5.9,0,0,0-.733-.576,1.089,1.089,0,0,0-.632-.158H1.464a.5.5,0,0,0,0,.992h0a.847.847,0,0,1,.6.307l.334.258a1.676,1.676,0,0,0,2.164.06c.176-.139.334-.317.51-.466a.663.663,0,0,1,.929,0l.362.347a1.687,1.687,0,0,0,2.284.07c.14-.11.251-.248.39-.367A.683.683,0,0,1,10,13.15c.017.015.422.406.422.406a1.667,1.667,0,0,0,1.634.367,1.961,1.961,0,0,0,.928-.6A.923.923,0,0,1,13.536,13h0a.5.5,0,0,0,0-.992ZM7.464,2.047A2.871,2.871,0,0,0,6.87,6.583a1.785,1.785,0,0,1,.562,1.694C7.119,9.17,6.342,10,6.774,11c.286-.971,1.367-1.291,1.861-2.124.99-1.565-.155-3-1.03-4.245C7.144,3.323,8.824,2.32,8.225,1A2.2,2.2,0,0,1,7.464,2.047Zm2.946,1.5a2.262,2.262,0,0,0,.525,3.106,1.059,1.059,0,0,1,.52,1.067c-.319.741-1.088,1.408-.686,2.28.374-.87,1.016-.644,1.817-1.546a2.261,2.261,0,0,0-.519-3.109,1.059,1.059,0,0,1-.527-1.067c.318-.741,1.088-1.406.687-2.278C11.855,2.87,11.211,2.645,10.41,3.547Zm-8,0a2.262,2.262,0,0,0,.525,3.106,1.059,1.059,0,0,1,.52,1.067c-.319.741-1.088,1.408-.686,2.28.374-.87,1.016-.644,1.817-1.546a2.261,2.261,0,0,0-.519-3.109A1.059,1.059,0,0,1,3.54,4.278C3.858,3.537,4.628,2.872,4.227,2,3.855,2.87,3.211,2.645,2.41,3.547Z"/> | ||
| <svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" id="hot-spring"> | ||
| <path d="M6.68243 5.75917C6.17755 5.03461 5.90147 4.63841 6.05256 3.38345 6.19176 2.22729 6.73053 1.76768 7.25024 1.32432 7.6543.979622 8.04684.64475 8.23115 0 8.53218.72151 8.1952 1.46958 7.88224 2.16432 7.57105 2.85514 7.28362 3.49322 7.67085 4 8.64208 5.27108 9.63433 6.87972 8.64208 8.58576 8.42776 8.97882 8.10321 9.2671 7.78077 9.55352 7.35829 9.92878 6.93943 10.3008 6.77686 10.9012 6.50799 10.2242 6.78522 9.53569 7.06149 8.84954 7.36728 8.09008 7.67188 7.33354 7.23353 6.59892 7.03059 6.25881 6.84469 5.99203 6.68243 5.75917ZM10.0533 4.58547C9.95503 3.95341 10.087 3.30458 10.4211 2.77653 10.7881 2.32699 11.1223 2.13424 11.4125 1.96681 11.7571 1.76802 12.0398 1.60493 12.2422 1.09012 12.5312 1.77367 12.2419 2.27826 11.938 2.80817 11.8193 3.01518 11.6983 3.22605 11.6088 3.45296 11.4174 4.06338 11.7099 4.34608 12.0755 4.69951 12.4336 5.04572 12.8619 5.4598 12.9744 6.3163 13.0578 6.95112 12.938 7.47257 12.602 8 12.246 8.43613 11.9212 8.65508 11.6374 8.84647 11.2813 9.08658 10.9895 9.2833 10.7809 9.81105 10.4894 9.12323 10.8123 8.55241 11.1343 7.98337 11.2573 7.76599 11.3801 7.54887 11.4685 7.32558 11.5415 6.76791 11.2348 6.4588 10.8872 6.10834 10.5304 5.74869 10.1305 5.3455 10.0533 4.58547ZM2.03512 4.58547C1.93689 3.95341 2.0401 3.28536 2.40296 2.77653 2.77929 2.24882 3.13207 2.05981 3.43808 1.89585 3.76141 1.72262 4.03253 1.57736 4.22408 1.09012 4.51269 1.77273 4.21029 2.29806 3.89884 2.83911 3.77657 3.05152 3.65291 3.26634 3.56306 3.49406 3.41122 3.87887 3.69362 4.50854 4.06372 4.73656 5.06535 5.53777 5.29084 7.02251 4.61098 8.0899 4.24538 8.53769 3.90721 8.73789 3.6119 8.91271 3.25876 9.12178 2.96692 9.29455 2.76278 9.81105 2.4847 9.15498 2.77094 8.63104 3.06243 8.09749 3.19329 7.85798 3.3252 7.61652 3.4076 7.36031 3.58665 6.80351 3.27319 6.47604 2.89763 6.0837 2.54859 5.71905 2.1459 5.29837 2.03512 4.58547Z"/> | ||
| <path d="M13 8.99995C13.7 11.6163 9.5263 12 7.49997 12C5.47364 12 1.29997 11.5163 1.99997 8.99995C1.36654 9.31626 0.999969 9.96092 0.999969 10.5C0.999969 12.0187 3.91012 13.3999 7.49997 13.3999C11.0898 13.3999 14 12.0187 14 10.5C14 9.96092 13.6334 9.31626 13 8.99995Z"/> | ||
| </svg> |
willymaps
reviewed
Jun 23, 2022
| <svg version="1.1" id="gift" xmlns="http://www.w3.org/2000/svg" width="15" height="15" viewBox="0 0 15 15"> | ||
| <path d="M6.5,5v2H0V5H6.5z M8.5,5v2H15V5H8.5z M1,8v4.5C1,13.3284,1.6716,14,2.5,14h4V8H1z M8.5,8v6h4c0.8284,0,1.5-0.6716,1.5-1.5
	V8H8.5z M10.5,0c-1.4033-0.0444-2.6497,0.8904-3,2.25C7.1497,0.8904,5.9033-0.0444,4.5,0c-1.0709-0.0337-1.9663,0.8072-2,1.8781
	C2.4987,1.9187,2.4987,1.9594,2.5,2C2.3443,2.9427,2.9822,3.8331,3.9249,3.9888C4.0853,4.0153,4.2486,4.0191,4.41,4h6.13
	c0.9548,0.1497,1.8503-0.5029,2-1.4577c0.0282-0.1797,0.0282-0.3626,0-0.5423c0.0002-1.1046-0.895-2.0002-1.9996-2.0004
	C10.5269-0.0004,10.5135-0.0003,10.5,0z M4.5,3c-0.506,0.0463-0.9537-0.3264-1-0.8323C3.4949,2.1119,3.4949,2.0558,3.5,2
	C3.4537,1.494,3.8264,1.0463,4.3323,1C4.3881,0.9949,4.4442,0.9949,4.5,1c1.1046,0,2,0.8954,2,2H4.5z M10.5,3h-2
	c0-1.1046,0.8954-2,2-2c0.5523,0,1,0.4477,1,1c0.0463,0.506-0.3264,0.9537-0.8323,1C10.6119,3.0051,10.5558,3.0051,10.5,3z"/> | ||
| <svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" id="gift"> | ||
| <path d="M10.5 1.00152C9.0967.957116 7.8503 1.89192 7.5 3.25152 7.1497 1.89192 5.9033.957116 4.5 1.00152 2.7678.947006 2.23515 2.79746 2.81831 4H1.5C1.22386 4 1 4.22386 1 4.5V5.5C1 5.77614 1.22386 6 1.5 6H13.5C13.7761 6 14 5.77614 14 5.5V4.5C14 4.22386 13.7761 4 13.5 4H12.1938C12.8 2.81516 12.2922 1.00143 10.5404 1.00112 10.5269 1.00112 10.5135 1.00122 10.5 1.00152ZM10.6831 4H8.5C8.50082 2.8961 9.3959 2.00152 10.5 2.00152 11.675 2.00152 11.8827 3.87414 10.6831 4ZM6.5 4H4.29187C3.25675 3.88256 3.19576 2.10553 4.3323 2.00152 4.3881 1.99642 4.4442 1.99642 4.5 2.00152 5.60409 2.00152 6.49918 2.8961 6.5 4ZM2 7.00146V11.5015C2 12.3299 2.6716 13.0015 3.5 13.0015H6.5V7.00146H2ZM8.5 7.00146V13.0015H11.5C12.3284 13.0015 13 12.3299 13 11.5015V7.00146H8.5Z"/> | ||
| </svg> |
willymaps
reviewed
Jun 23, 2022
| <svg version="1.1" id="toilet" xmlns="http://www.w3.org/2000/svg" width="15" height="15" viewBox="0 0 15 15"> | ||
| <path d="M4.5,3C3.6716,3,3,2.3284,3,1.5S3.6716,0,4.5,0S6,0.6716,6,1.5S5.3284,3,4.5,3z M14,1.5C14,0.6716,13.3284,0,12.5,0
	S11,0.6716,11,1.5S11.6716,3,12.5,3S14,2.3284,14,1.5z M8.86,6.64L8.86,6.64L6.38,4.15l0,0C6.2798,4.0492,6.142,3.9949,6,4H3
	C2.8697,4.0003,2.7445,4.0503,2.65,4.14l0,0L0.14,6.63c-0.2261,0.177-0.2659,0.5039-0.0889,0.73s0.5039,0.2659,0.73,0.0889
	C0.8142,7.423,0.8441,7.3931,0.87,7.36L3,5.2L1,11h2v3.33c-0.0075,0.0497-0.0075,0.1003,0,0.15
	c0.0555,0.2761,0.3244,0.455,0.6005,0.3995C3.802,14.839,3.9595,14.6815,4,14.48l0,0V11h1v3.5l0,0
	c0.0555,0.2761,0.3244,0.455,0.6005,0.3995C5.802,14.859,5.9595,14.7015,6,14.5c0.0075-0.0497,0.0075-0.1003,0-0.15V11h2L6,5.2
	l2.14,2.16l0,0c0.0967,0.1081,0.2349,0.17,0.38,0.17C8.7954,7.5088,9.0061,7.2761,9,7C9.0023,6.8663,8.9521,6.737,8.86,6.64z
	 M14.5,4h-4C10.2239,4,10,4.2239,10,4.5v5c0,0.2761,0.2239,0.5,0.5,0.5S11,9.7761,11,9.5v5c0,0.2761,0.2239,0.5,0.5,0.5
	s0.5-0.2239,0.5-0.5v-5h1v5c0,0.2761,0.2239,0.5,0.5,0.5s0.5-0.2239,0.5-0.5v-5c0,0.2761,0.2239,0.5,0.5,0.5S15,9.7761,15,9.5v-5
	C15,4.2239,14.7761,4,14.5,4z"/> | ||
| <svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" id="toilet"> | ||
| <path d="M3 1.5C3 2.3284 3.6716 3 4.5 3 5.3284 3 6 2.3284 6 1.5 6 .6716 5.3284 0 4.5 0 3.6716 0 3 .6716 3 1.5ZM11.5 0C12.3284 0 13 .6716 13 1.5 13 2.3284 12.3284 3 11.5 3 10.6716 3 10 2.3284 10 1.5 10 .6716 10.6716 0 11.5 0ZM3.29016 4C2.9313 4 2.59996 4.19229 2.42192 4.50386L.565878 7.75193C.428873 7.99169.512172 8.29712.75193 8.43412.991689 8.57113 1.29712 8.48783 1.43412 8.24807L2.84648 5.77645C2.40395 6.99528 1.76202 8.79015 1 11H3V14.33C2.9925 14.3797 2.9925 14.4303 3 14.48 3.0555 14.7561 3.3244 14.935 3.6005 14.8795 3.802 14.839 3.9595 14.6815 4 14.48V11H5V14.5C5.0555 14.7761 5.3244 14.955 5.6005 14.8995 5.802 14.859 5.9595 14.7015 6 14.5 6.0075 14.4503 6.0075 14.3997 6 14.35V11H8L6.10265 5.68742 7.56588 8.24807C7.70288 8.48783 8.00831 8.57113 8.24807 8.43412 8.48783 8.29712 8.57113 7.99169 8.43412 7.75193L6.57808 4.50386C6.40004 4.19229 6.0687 4 5.70984 4H3.29016ZM9 4.5C9 4.2239 9.2239 4 9.5 4H13.5C13.7761 4 14 4.2239 14 4.5V9.5C14 9.7761 13.7761 10 13.5 10 13.2239 10 13 9.7761 13 9.5V14.5C13 14.7761 12.7761 15 12.5 15 12.2239 15 12 14.7761 12 14.5V9.5H11V14.5C11 14.7761 10.7761 15 10.5 15 10.2239 15 10 14.7761 10 14.5V9.5C10 9.7761 9.7761 10 9.5 10 9.2239 10 9 9.7761 9 9.5V4.5Z"/> | ||
| </svg> |
There was a problem hiding this comment.
I see it exists in the previous version as well, but should all feet be touching the bottom?
There was a problem hiding this comment.
Good point! I fixed it ❤️
willymaps
reviewed
Jun 23, 2022
There was a problem hiding this comment.
@Udobnyj such an improvement here! In addition to the comments I made, I also noticed some unnecessary <g> tags that were potentially introduced here. Can you please update:
slipwayslaughterhouseconstructionrestaurant-pizzasnowmobile
Udobnyj
force-pushed
the
size-consistency
branch
from
2391c86 to
ec4ec12
Compare
Udobnyj
force-pushed
the
size-consistency
branch
from
cfe97ae to
0605e95
Compare
|
I feel an incredible thrill pressing the merge button 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this Size consistency task, I changed 34 maki icons