Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Response Types #406

Merged
merged 25 commits into from
Apr 4, 2020
Merged

Conversation

JThramer
Copy link
Contributor

@JThramer JThramer commented Jan 17, 2020

Implements #391.

To-Do:

Nothing! 🎉

Done:

  • Documentation
  • Add error case that handles a no-connection situation.
  • PR Comments
  • Fix Tests
  • DirectionsError needs to be Codable
  • DirectionsCredentials on Directions class that contains accessToken, host, and skuToken, copied to response on calculate
    Convert a match response into a route response:
  • Matches need to be convertible to Routes
  • MapMatchingResponse needs to be convertible to RouteResponse
  • MatchOptions needs to be convertible to RouteOptions

cc @mapbox/navigation-ios

@JThramer JThramer self-assigned this Jan 17, 2020
@JThramer JThramer added backwards incompatible changes that break backwards compatibility of public API improvement Improvement for an existing feature. labels Jan 17, 2020
@JThramer JThramer added this to the v1.0 milestone Jan 17, 2020
Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/RouteResponse.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/RouteResponse.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/RouteResponse.swift Outdated Show resolved Hide resolved
@JThramer JThramer marked this pull request as ready for review February 13, 2020 00:17
@JThramer JThramer requested a review from 1ec5 February 18, 2020 02:40
Copy link
Contributor

@Udumft Udumft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some questions not clear for me. It may be not blocking since maybe I just lack some understanding of the map matching requests. Anyway please check the comments before merging.

@Udumft
Copy link
Contributor

Udumft commented Apr 4, 2020

At this point these changes heavily conflict with #388 . I would be important to have #406 merged before continuing #388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards incompatible changes that break backwards compatibility of public API improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants