Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iOS 11 support. #736

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Remove iOS 11 support. #736

merged 1 commit into from
Sep 21, 2022

Conversation

MaximAlien
Copy link
Contributor

PR increases minimum deployment targets to:

  • iOS 12.0
  • tvOS 12.0
  • macOS 10.14
  • watchOS 5.0

@MaximAlien MaximAlien requested a review from a team September 13, 2022 05:00
@MaximAlien MaximAlien self-assigned this Sep 13, 2022
Cartfile Outdated
@@ -1,2 +1,2 @@
github "raphaelmor/Polyline" ~> 5.0
github "MaximAlien/Polyline" "master"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New release of Polyline with updated deployment targets is needed. PR can be found here: raphaelmor/Polyline#78.

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changelog entry:

  • This library now requires a minimum deployment target of iOS 12.0 or above, macOS 10.14.0 or above, tvOS 12.0 or above, or watchOS 5.0 or above. Older operating system versions are no longer supported. (#736)

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1340"
LastUpgradeVersion = "1400"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#730 will consolidate the schemes and targets, making future upgrades cleaner.

@1ec5 1ec5 added the build label Sep 13, 2022
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the podspec:

s.ios.deployment_target = "10.0"
s.osx.deployment_target = "10.12"
s.watchos.deployment_target = "3.0"
s.tvos.deployment_target = "10.0"

@@ -1,2 +1,2 @@
github "raphaelmor/Polyline" == 5.0.3
github "raphaelmor/Polyline" ~> 5.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to pin to specific version of Polyline anymore.

@MaximAlien MaximAlien added this to the v2.8 milestone Sep 21, 2022
@MaximAlien MaximAlien merged commit 51a2976 into main Sep 21, 2022
@MaximAlien MaximAlien deleted the maxim/remove-ios-11-support branch September 21, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants