-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove iOS 11 support. #736
Conversation
Cartfile
Outdated
@@ -1,2 +1,2 @@ | |||
github "raphaelmor/Polyline" ~> 5.0 | |||
github "MaximAlien/Polyline" "master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New release of Polyline with updated deployment targets is needed. PR can be found here: raphaelmor/Polyline#78.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changelog entry:
- This library now requires a minimum deployment target of iOS 12.0 or above, macOS 10.14.0 or above, tvOS 12.0 or above, or watchOS 5.0 or above. Older operating system versions are no longer supported. (#736)
@@ -1,6 +1,6 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<Scheme | |||
LastUpgradeVersion = "1340" | |||
LastUpgradeVersion = "1400" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#730 will consolidate the schemes and targets, making future upgrades cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update the podspec:
mapbox-directions-swift/MapboxDirections.podspec
Lines 28 to 31 in 8c275c9
s.ios.deployment_target = "10.0" | |
s.osx.deployment_target = "10.12" | |
s.watchos.deployment_target = "3.0" | |
s.tvos.deployment_target = "10.0" |
47f4056
to
37ca4f2
Compare
a88f5b6
to
555a429
Compare
@@ -1,2 +1,2 @@ | |||
github "raphaelmor/Polyline" == 5.0.3 | |||
github "raphaelmor/Polyline" ~> 5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to pin to specific version of Polyline anymore.
PR increases minimum deployment targets to: