[android] #3535 - improve disabling tracking modes

mapbox · Jan 14, 2016 · 1f31de2 · 1f31de2
1 parent 5d9485e
commit 1f31de2
Showing 1 changed file with 26 additions and 10 deletions.
diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/views/MapView.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/views/MapView.java
@@ -3132,16 +3132,6 @@ public boolean onDown(MotionEvent event) {
                 mZoomButtonsController.setVisible(true);
             }
 
-            // Disable tracking mode if a gesture occurs
-            try {
-                //noinspection ResourceType
-                setMyLocationTrackingMode(MyLocationTracking.TRACKING_NONE);
-                //noinspection ResourceType
-                setMyBearingTrackingMode(MyBearingTracking.NONE);
-            } catch (SecurityException ignore) {
-                // User did not accept location permissions
-            }
-
             return true;
         }
 
@@ -3294,6 +3284,9 @@ public boolean onFling(MotionEvent e1, MotionEvent e2, float velocityX,
                 return false;
             }
 
+            // reset tracking modes if gesture occurs
+            resetTrackingModes();
+
             // Fling the map
             float ease = 0.25f;
 
@@ -3323,6 +3316,9 @@ public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX, float d
                 return false;
             }
 
+            // reset tracking modes if gesture occurs
+            resetTrackingModes();
+
             // Cancel any animation
             mNativeMapView.cancelTransitions();
 
@@ -3350,6 +3346,9 @@ public boolean onScaleBegin(ScaleGestureDetector detector) {
                 return false;
             }
 
+            // reset tracking modes if gesture occurs
+            resetTrackingModes();
+
             mBeginTime = detector.getEventTime();
             return true;
         }
@@ -3420,6 +3419,9 @@ public boolean onRotateBegin(RotateGestureDetector detector) {
                 return false;
             }
 
+            // reset tracking modes if gesture occurs
+            resetTrackingModes();
+
             mBeginTime = detector.getEventTime();
             return true;
         }
@@ -3496,6 +3498,9 @@ public boolean onShoveBegin(ShoveGestureDetector detector) {
                 return false;
             }
 
+            // reset tracking modes if gesture occurs
+            resetTrackingModes();
+
             mBeginTime = detector.getEventTime();
             return true;
         }
@@ -4212,6 +4217,17 @@ public void setOnMyBearingTrackingModeChangeListener(@Nullable OnMyBearingTracki
         mOnMyBearingTrackingModeChangeListener = listener;
     }
 
+    private void resetTrackingModes(){
+        try {
+            //noinspection ResourceType
+            setMyLocationTrackingMode(MyLocationTracking.TRACKING_NONE);
+            //noinspection ResourceType
+            setMyBearingTrackingMode(MyBearingTracking.NONE);
+        } catch (SecurityException ignore) {
+            // User did not accept location permissions
+        }
+    }
+
     //
     // Compass
     //