This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Tiles LOD: load and render based on zoom when displayed #15230
Draft
astojilj
wants to merge
2
commits into
master
Choose a base branch
from
astojilj-lod
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astojilj
force-pushed
the
astojilj-near-horizon
branch
from
July 27, 2019 10:44
b21b82c
to
bd3f137
Compare
1ec5
reviewed
Jul 29, 2019
* center of the screen, max pitch is further capped by Transform::getMaxPitchForEdgeInsets. | ||
* We set the max to 70 to keep the limit constant with small padding. | ||
*/ | ||
constexpr double PITCH_MAX = 70 * DEG2RAD; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the iOS map SDK is currently using this constant to fake a tilted annotation view specifically for the user dot / user puck:
mapbox-gl-native/platform/ios/src/MGLAnnotationView.mm
Lines 162 to 165 in b6dd995
// The pitch intensity represents how much the map view is actually pitched compared to | |
// what is possible. The value will range from 0% (not pitched at all) to 100% (pitched as much | |
// as the map view will allow). The map view's maximum pitch is defined in `mbgl::util::PITCH_MAX`. | |
CGFloat pitchIntensity = pitch / MGLDegreesFromRadians(mbgl::util::PITCH_MAX); |
Though something like mapbox/ios-sdk-examples#111 (comment) would be a much sounder approach long-term: #10498.
friedbunny
added
Core
The cross-platform C++ core, aka mbgl
needs changelog
Indicates PR needs a changelog entry prior to merging.
rendering
performance
Speed, stability, CPU usage, memory usage, or power usage
labels
Jul 29, 2019
astojilj
force-pushed
the
astojilj-near-horizon
branch
from
August 1, 2019 05:14
bd3f137
to
f37d81d
Compare
Unit test verifies that, with different camera parameters combinations LOD tile cover covers all tiles returned by single level tileCover.
Update: |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Core
The cross-platform C++ core, aka mbgl
needs changelog
Indicates PR needs a changelog entry prior to merging.
performance
Speed, stability, CPU usage, memory usage, or power usage
rendering
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attached video shows 70 degree pitch on iPadMini2: ipadmini270degpitch.mp4.zip
Fixes #9037, #15163