Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize test names #186

Merged
merged 6 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Guide: https://keepachangelog.com/en/1.0.0/

<!-- Add changes for active work here -->

- [Tests] Reorganize tests based on API type

- [Privacy] Add Search history collected data for the purpose of product personalization (used for displaying the search history)

- [Discover, Category] Rename Discover to Category and update tests.
Expand Down
114 changes: 64 additions & 50 deletions MapboxSearch.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions Tests/Demo.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@
{
"skippedTests" : [
"BaseTestCase",
"FavoritesIntegrationTestCase\/testAddEditLocationRemoveFavorite()",
"FavoritesIntegrationTestCase\/testAddRemoveFavorite()",
"FavoritesIntegrationTestCase\/testAddRenameCancelRemoveFavorite()",
"FavoritesIntegrationTestCase\/testAddRenameRemoveFavorite()",
"FavoritesUITestCase\/testAddEditLocationRemoveFavorite()",
"FavoritesUITestCase\/testAddRemoveFavorite()",
"FavoritesUITestCase\/testAddRenameCancelRemoveFavorite()",
"FavoritesUITestCase\/testAddRenameRemoveFavorite()",
"MockServerUITestCase"
],
"target" : {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import XCTest

// Rename to UITestCase
class CategorySuggestionsNavigationIntegrationTestCase: MockSearchBoxUITestCase {
class CategorySuggestionsNavigationUITestCase: MockSearchBoxUITestCase {
override func setUpWithError() throws {
try super.setUpWithError()
app.launch()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import XCTest

// Rename to UITestCase
class CategorySuggestionsIntegrationTestCase: MockSearchBoxUITestCase {
class CategorySuggestionsUITestCase: MockSearchBoxUITestCase {
override func setUpWithError() throws {
try super.setUpWithError()
app.launch()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import XCTest

// Rename to UITestCase
class FavoritesIntegrationTestCase: MockSearchBoxUITestCase {
class FavoritesUITestCase: MockSearchBoxUITestCase {
func testAddRemoveFavorite() throws {
try server.setResponse(.suggestMinsk)
try server.setResponse(.retrieveMinsk)
Expand Down Expand Up @@ -233,7 +232,7 @@ class FavoritesIntegrationTestCase: MockSearchBoxUITestCase {
}
}

extension FavoritesIntegrationTestCase {
extension FavoritesUITestCase {
func removeDefaultFavorite(element: XCUIElement) {
element.buttons["moreButton"].tap()
let removeLocation = app.buttons["Remove location"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import XCTest

// TODO: Analytics

// Rename to UITestCase
class FeedbackIntegrationTestCase: MockSearchBoxUITestCase {
class FeedbackUITestCase: MockSearchBoxUITestCase {
override func setUpWithError() throws {
try super.setUpWithError()

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import XCTest

// Rename to UITestCase
class SearchIntegrationTestCase: MockSearchBoxUITestCase {
class SearchUITestCase: MockSearchBoxUITestCase {
func testRecentSearchRemove() throws {
try server.setResponse(.suggestSanFrancisco)
try server.setResponse(.retrieveSanFrancisco)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import XCTest

// Rename to UITestCase
class VisibilityTestCase: MockSearchBoxUITestCase {
class VisibilityUITestCase: MockSearchBoxUITestCase {
override func setUpWithError() throws {
try super.setUpWithError()
app.launch()
Expand Down
1 change: 0 additions & 1 deletion Tests/MockData/sbs/move-existing-mocks-here.txt

This file was deleted.