Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSDK-595] Prepare 2.0.0-rc.3 release #190

Merged
merged 5 commits into from
Mar 28, 2024
Merged

[SSDK-595] Prepare 2.0.0-rc.3 release #190

merged 5 commits into from
Mar 28, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Mar 12, 2024 •
edited by mbahar
Loading

Description

Fixes https://mapbox.atlassian.net/browse/SSDK-595

  • [Core] Add SearchResultAccuracy.proximate case, which signifies that the result is a known address point but does not intersect a known rooftop/parcel.
  • [UI] Add Right-to-Left language support for Categories/Favorites segment control and fix xib errors.
  • [UI] Add Preview file for CategoriesFavoritesSegmentControl to fix compiler problems.
  • [Core] Add SearchError.owningObjectDeallocated when network responses fail to unwrap guard-let-self. If you encounter this error you must own the reference to the search engine.
  • [Tests] Add UnownedObjectError tests to validate the behavior of SearchError.owningObjectDeallocated.
  • [Privacy] Add Search history data collected for the purpose of product personalization (used for displaying the search history)
  • [Discover, Category] Discover API to query categories remains available and compatible with 1.0.0 series.
  • [Core] Default API engine type remains SBS (/search/v1), and the new Search Box API (search/searchbox/v1) is available by opt-in.
  • [License] Update license to reflect 2024 usage
  • [Tests] Change MockResponse into a protocol, create separate enums conforming to MockResponse for each API type (geocoding, SBS, autofill), and add MockResponse as generic to each test base class and MockWebServer.
  • [Tests] Reorganize tests based on API type
  • [Core] Update MapboxCoreSearch to the version built with Xcode 15.3

MapboxCoreSearch: v2.0.0-alpha.14

Checklist

  • Update CHANGELOG

@aokj4ck aokj4ck marked this pull request as ready for review March 12, 2024 17:35
@aokj4ck aokj4ck requested review from a team as code owners March 12, 2024 17:35
@aokj4ck aokj4ck mentioned this pull request Mar 19, 2024
Closed
mapbox-danny
mapbox-danny approved these changes Mar 28, 2024
View reviewed changes
Copy link

@mapbox-danny mapbox-danny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aokj4ck aokj4ck merged commit 5e56456 into main Mar 28, 2024
5 checks passed
@aokj4ck aokj4ck deleted the release/2.0.0-rc.3 branch March 28, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapbox-danny mapbox-danny mapbox-danny approved these changes

@mbahar mbahar mbahar approved these changes

@azarovalex azarovalex Awaiting requested review from azarovalex azarovalex is a code owner automatically assigned from mapbox/search-sdk

@ahmedaly16 ahmedaly16 Awaiting requested review from ahmedaly16 ahmedaly16 is a code owner automatically assigned from mapbox/search-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aokj4ck @mbahar @mapbox-danny