Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSDK-582] Update SearchCore for PrivacyInfo.xcprivacy #220

Merged
merged 14 commits into from
May 2, 2024
Merged

[SSDK-582] Update SearchCore for PrivacyInfo.xcprivacy #220

merged 14 commits into from
May 2, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Apr 26, 2024 •
edited
Loading

Description

Fixes https://mapbox.atlassian.net/browse/SSDK-582

  1. Update .swift-version for package checksum
  2. Update Cartfile (local project) and Package.swift (MapboxSearch and MapboxSearchUI) for MapboxSearchCore update including PrivacyInfo.xcprivacy
  3. Resolve project with Xcode 15.3 (updating Package.resolved)
  4. Update CI config

Checklist

  • Update CHANGELOG

@aokj4ck aokj4ck requested review from a team as code owners April 26, 2024 17:54
@aokj4ck aokj4ck mentioned this pull request Apr 26, 2024
Closed
mikeringrose
mikeringrose previously approved these changes Apr 26, 2024
View reviewed changes
@aokj4ck
Copy link
Contributor Author

aokj4ck commented Apr 30, 2024

This just needs an updated MapboxCoreSearch.

@aokj4ck aokj4ck enabled auto-merge (squash) May 2, 2024 16:57
@aokj4ck aokj4ck merged commit f7cc1e7 into main May 2, 2024
3 checks passed
@aokj4ck aokj4ck deleted the xcprivacy-searchcore_beta17 branch May 2, 2024 17:10
mapbox-danny
mapbox-danny approved these changes May 2, 2024
View reviewed changes
Copy link

@mapbox-danny mapbox-danny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedaly16 ahmedaly16 ahmedaly16 approved these changes

@mapbox-danny mapbox-danny mapbox-danny approved these changes

@mikeringrose mikeringrose mikeringrose left review comments

@globaltrouble globaltrouble Awaiting requested review from globaltrouble globaltrouble is a code owner automatically assigned from mapbox/search-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aokj4ck @mikeringrose @mapbox-danny @ahmedaly16