Fix 647 Support Node 18 as Target

[ronilan]

Overview

This pull request fixes #647

Change

• Updated abi_crosswalk.json to include node 18 (current) (via script).
• Added test coverage for cases of unsupported/unknown targets.

[acalcutt]

Would love to see this merged for the node 18 support

[axrj]

Thanks!

[axrj]

Hey! I noticed CI job is missing for node 18, mind adding that?

[ronilan]

Hey! I noticed CI job is missing for node 18, mind adding that?

@axrj assuming this was referring me, I wrote this PR (and all others leading to #656) last year using two weeks of @solarwindscloud time. I’m no longer on their paycheck (and I think they moved away from this package, @cheempz can confirm).

As said earlier this year in #657, if there is interest from corporate users of the package to fund more active maintenance and/or tackling some of the more prominent open issues, and/or potentially taking it off @mapbox - I should be technically able.

[cclauss]

• run.util.js: Test building with msvs 2022 and get AppVeyor to pass #709
• Error: Unsupported target versions: Node.js > v17 #710

[cclauss]

@ronilan, @ewanharris Would you be willing to collaborate to make a single pull request that supports all current versions of Node.js with successful AppVeyor tests?

@ronilan you could bring in the changes from #709 into this pull request and update support for Node.js up to v21 to lib/util/abi_crosswalk.json.

@ewanharris you could help me to add your patch-package trick (#710 (comment)) to the AppVeyor process.

By combining our knowledge we should provide a working example of taking the current codebase and patching in updates to lib/util/abi_crosswalk.json and passing tests on all currently supported versions of Node.js.

Thoughts?

[ewanharris]

@cclauss the patch-package process is more for consumers of node-pre-gyp to workaround the lack of updates, it allows patching the abi_crosswalk.json file after installing node_modules to allow builds to work on newer versions.

I'd be happy to PR an updated abi_crosswalk.json file to the branch for this update in @ronilan's repo so that this PR then gets updated with the latest versions once that PR is merged, or I can PR onto the branch used for #709

[acalcutt]

Just an FYI for anyone interested. I have updated abi_crosswalk.json to node 21 in my fork of node-pre-gyp at @acalcutt/node-pre-gyp , which I forked for the node version of maplibre-native (a fork of mapbox-native).

Unfortunately it doesn't seem like anyone is maintaining this here.... since this has been open a while with no interest and now needs further updating.

[acalcutt]

I added #711 to update abi_crosswalk.json to node 21 if anyone is interested in updating the support.

[acalcutt]

I added a second PR #712 which I think makes the changes requsted by @cclauss in #649 (comment) , which is an alternate to #711