-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add windows build #6
Conversation
The error on the Windows build is:
Which might be related to these earlier messages:
Seems like either CMake didn't generate the |
Removed some unused variables
Also tried a shorter way of setting the compilers.
Also raised minimum CMake version to match the one of Aseprite.
CCache does claim support for MSVC at https://ccache.dev/platform-compiler-language-support.html but the build doesn't seem to use it automatically like on Linux and macOS.
That's what you get from blindly trying suggestions by AI...
Alright, at least the MSVC build succeeded, but the install location could be improved:
In our build environment, something is setting a |
* Set RUNTIME DESTINATION, which is used for DLLs * Use MODULE instead of SHARED, to avoid creating (and installing) a needless .lib file on Windows.
Whoops, after merging this I noticed the "32-bit" build is actually also a 64-bit build. I should have used |
Not working right now, but it's a start. There's no clear error message I can see in the output
Maybe the install step needs some adjustment on windows?
Closes #5