Fix documentation build/deployment Action #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
approved these changes
Nov 15, 2023
|
@hrshdhgd can you check this as well? |
|
It looks like 1/4 tasks are complete. Is that true or an oversight. I didn't review it assuming that the PR is incomplete because of that. |
|
Other than that, looks good. |
|
My apologies, I hadn't checked off some of those boxes because they weren't applicable to this PR, but we're good to 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/have been added/updated if necessarymake testhas been run locallyThe documentation build Action triggered after merging in PR #333 didn't go through: https://github.com/mapping-commons/sssom/actions/runs/6862846838, and that is because I had forgotten to include the updated pyproject.toml/poetry.lock files in that PR. Merging in this PR will fix that. I also updated the deploy_documentation.yaml workflow to use the Makefile target to build the docs rather than writing out the full commands.