-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curie_map
to the model
#376
Conversation
Now that the SSSOM model formally includes a `curie_map` slot, we can amend the spec to: 1. describe the purpose of that slot in the general description of the model; 2. rephrase the section about that slot in the specification of the SSSOM/TSV format, to remove the notion that this slot is a "supplementary slot" that is specific to the TSV format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the "example" after all, just for completeness reasons. One small comment, then we can merge.
Awesome thank you!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
While the single value is allowed, we want to discourage it. Thanks @gouttegd for the note about this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to repeat this in every PR
run make all
same as #386 (review)
No need to be sorry. :) However:
It would be much better in my opinion to leave the auto-generated files untouched most of the times, and only commit them once in a while (typically shortly before a release).
And since there is a PR template, that requirement should also be mentioned in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Resolves #225
docs/
have been added/updated if necessarymake test
has been run locallyIf you are proposing a change to the SSSOM metadata model, you must
examples/
(no need for a new example – all existing examples already have acurie_map
)see_also
field of the linkml modelsee_also
field of the linkml model (no need, see above)This PR makes the
curie_map
a bona fide slot of theMappingSet
class, that exists independently of the serialisation format.It builds on top of #349 by explaining in the text version of the spec what the
curie_map
slot is for, and how it should be dealt with in the SSSOM/TSV serialisation.