Fix issue 180. WrongUsageOfMappersFactory componentModel from config #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiphr
reviewed
Apr 2, 2024
src/main/java/org/mapstruct/intellij/inspection/WrongUsageOfMappersFactoryInspection.java
Outdated
Show resolved
Hide resolved
|
@filiphr Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support to read the
componentModelfrom aMapperConfigforWrongUsageOfMappersFactoryInspectionsee #180 .I only added the quickfix to remove
Mappersusage. I think it is more intuitive to not write to other files for this. If we want to support this we must ensure that we could write to theMapperConfig(could be provided as a dependency for example).