-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add idea 2024.1 to build matrix #189
add idea 2024.1 to build matrix #189
Conversation
e66d99c
to
a233bea
Compare
I also update c |
@hduelme Thanks. Interestingly now v3 seems to fail when uploading it. Any idea why that happens? |
@thunderhook yes it's a known issue of codecov see codecov/codecov-action#598 Seems like they published a v4 to address this issue. |
One thing to not is that tokenless uploading is no longer supported in v4. If the project currently doesn't have a token see https://docs.codecov.com/docs/adding-the-codecov-token#github-actions |
OK, next time I'll leave the merge to you @filiphr 😅 Pipeline looked good (see details above) and everything went fine: The main branch can't upload the coverage report now due to the missing token: So we'll have to add a token now. |
@thunderhook I've added the token in 4fa44fb. However, it seems like the coverage is now 0 (https://app.codecov.io/github/mapstruct/mapstruct-idea). Perhaps something is not correct with what Jacoco generates |
Added latest released version to build matrix