implement new parse for text height

marc2332 · Oct 16, 2024 · e7caef3 · e7caef3
1 parent c32dd2c
commit e7caef3
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/crates/state/src/values/text_height.rs b/crates/state/src/values/text_height.rs
@@ -6,14 +6,16 @@ use crate::{
 };
 
 impl Parse for TextHeightBehavior {
-    fn parse(value: &str) -> Result<Self, ParseError> {
-        match value {
-            "all" => Ok(TextHeightBehavior::All),
-            "disable-first-ascent" => Ok(TextHeightBehavior::DisableFirstAscent),
-            "disable-least-ascent" => Ok(TextHeightBehavior::DisableLastDescent),
-            "disable-all" => Ok(TextHeightBehavior::DisableAll),
-            _ => Err(ParseError),
-        }
+    fn from_parser(parser: &mut Parser) -> Result<Self, ParseError> {
+        parser.consume_map(|value| {
+            value.try_as_str().and_then(|value| match value {
+                "all" => Some(TextHeightBehavior::All),
+                "disable-first-ascent" => Some(TextHeightBehavior::DisableFirstAscent),
+                "disable-least-ascent" => Some(TextHeightBehavior::DisableLastDescent),
+                "disable-all" => Some(TextHeightBehavior::DisableAll),
+                _ => None,
+            })
+        })
     }
 }