Merge branch 'main' into chore/replace-dioxus-sdk-with-dioxus-clipboard

.gitignore

@@ -3,4 +3,5 @@ Cargo.lock
 .idea
 snapshot_before.png
 snapshot_after.png
-documents_example
+documents_example
+bacon.toml

CONTRIBUTING.md

@@ -24,9 +24,9 @@ cargo +nightly fmt --all -- --error-on-unformatted --unstable-features
 Freya is split in various crates, each with it's own meaning and purpose, here is the list sorted by their importance:
 
 - `freya`: Entrypoint to the library used by end users, mainly reexports the other crates and contains the launch methods.
-- `renderer`: GUI Renderer using Winit and a Skia Canvas to render the app.
-- `core`: Core logic for events, DOM processing, accessibility integration and text layout measurement is located here.
-- `native-core`: DOM tree-like data structure to hold all the nodes with their attribute values and registered event handlers.
+- `renderer`: Provides a winit event loop based execution for the app.
+- `core`: Core logic for events, DOM processing, accessibility integration, element rendering and text layout measurement is located here.
+- `native-core`: DOM data structure to hold all the nodes with their attribute values and registered event handlers.
 - `torin`: UI layout library specifically made for Freya, although it's agnostic.
 - `hooks`: Various Dioxus hooks to be used in Freya apps (text editing, animation, theming, etc)
 - `components`: Collection of built-in Dioxus components to be used out of the box with in Freya apps (Button, Switch, Slider, Table, ScrollView, etc)
@@ -38,6 +38,8 @@ Freya is split in various crates, each with it's own meaning and purpose, here i
 - `native-core-macro`: Just some internal macros to be used in `states` so it can be integrated with `native-core`.
 - `common`: Some simple utilities used across the different Freya crates.
 
+![Overview](./.github/overview.png)
+
 ## Examples
 All important examples are located in the  `./examples` folder although you might also find some in the form of docs comments in the code itself.
 

README.md

@@ -8,13 +8,12 @@
 
 [Website](https://freyaui.dev) | [Nightly Docs](https://docs.freyaui.dev/freya) | [Stable Docs](https://docs.rs/freya/latest/freya) | [Book](https://book.freyaui.dev) | [Discord](https://discord.gg/sYejxCdewG)
 
-**Freya** is a cross-paltform GUI library for Rust powered by 🧬 [Dioxus](https://dioxuslabs.com) and 🎨 [Skia](https://skia.org/). 
+**Freya** is a cross-platform GUI library for Rust powered by 🧬 [Dioxus](https://dioxuslabs.com) and 🎨 [Skia](https://skia.org/). 
 
 **It does not use any web tech**, check the [Differences with Dioxus](https://book.freyaui.dev/differences_with_dioxus.html). 
 
 ⚠️ It's currently work in progress, but you can already play with it! You can join the [Discord](https://discord.gg/sYejxCdewG) server if you have any question or issue. 
 
-<br/>
 <br/>
 
 <table>
@@ -66,12 +65,6 @@ fn app() -> Element {
 </td>
 </table>
 
-### Sponsors 🤗
-
-Thanks to my sponsors for supporting this project! 😄
-
-<!-- sponsors --><a href="https://github.com/piny4man"><img src="https:&#x2F;&#x2F;avatars.githubusercontent.com&#x2F;u&#x2F;8446285?u&#x3D;fd37db4dd9b4ba94dabe0bccc3a95ef2a35376ab&amp;v&#x3D;4" width="60px" alt="" /></a><a href="https://github.com/gqf2008"><img src="https:&#x2F;&#x2F;avatars.githubusercontent.com&#x2F;u&#x2F;2295878?v&#x3D;4" width="60px" alt="高庆丰" /></a><!-- sponsors -->
-
 ### Want to try it? 🤔
 
 👋 Make sure to check the [Setup guide](https://book.freyaui.dev/setup.html) first.
@@ -93,19 +86,21 @@ Add Freya and Dioxus as dependencies:
 freya = "0.2"
 dioxus = { version = "0.5", features = ["macro", "hooks"], default-features = false }
 ```
+### Contributing 🧙‍♂️
+
+If you are interested in contributing please make sure to have read the [Contributing](CONTRIBUTING.md) guide first!
 
 ### Features ✨
 - ⛏️ Built-in **components** (button, scroll views, switch and more) 
-- 🚇 Built-in **hooks** library (animations, text editing and more)
-- 🔍 Built-in **devtools** panel
+- 🚇 Built-in **hooks** (animations, text editing and more)
+- 🔍 Built-in **developer tools** (tree inspection, fps overlay)
 - 🧰 Built-in **headless runner** to test UI
-- 🎨 **Theming** support (not extensible yet ⚠️)
+- 🎨 **Theming** support
 - 🛩️ **Cross-platform** (Windows, Linux, MacOS)
 - 🖼️ SKSL **Shaders** support
-- 🔄️ Dioxus **Hot-reload** support
 - 📒 Multi-line **text editing**
-- 🦾 Basic **Accessibility** Support (experimental ⚠️)
-- 🧩Compatible with dioxus-sdk and other Dioxus renderer-agnostic libraries
+- 🦾 **Accessibility** support
+- 🧩 Compatible with dioxus-sdk and other Dioxus renderer-agnostic libraries
 
 ### Goals 😁
 - Performant and low memory usage
@@ -115,6 +110,22 @@ dioxus = { version = "0.5", features = ["macro", "hooks"], default-features = fa
 - Useful testing APIs
 - Useful and extensible built-in components and hooks
 
+### Support 🤗
+
+If you are interested in supporting the development of this project feel free to donate to my [Github Sponsor](https://github.com/sponsors/marc2332/) page.
+
+Thanks to my sponsors for supporting this project! 😄 
+
+<!-- sponsors --><a href="https://github.com/piny4man"><img src="https:&#x2F;&#x2F;avatars.githubusercontent.com&#x2F;u&#x2F;8446285?u&#x3D;fd37db4dd9b4ba94dabe0bccc3a95ef2a35376ab&amp;v&#x3D;4" width="60px" alt="" /></a><a href="https://github.com/gqf2008"><img src="https:&#x2F;&#x2F;avatars.githubusercontent.com&#x2F;u&#x2F;2295878?v&#x3D;4" width="60px" alt="高庆丰" /></a><!-- sponsors -->
+
+### Special thanks 💪
+
+- [Jonathan Kelley](https://github.com/jkelleyrtp) and [Evan Almloff](https://github.com/ealmloff) for making [Dioxus](https://dioxuslabs.com/) and all their help, specially when I was still creating Freya.
+- [Armin](https://github.com/pragmatrix) for making [rust-skia](https://github.com/rust-skia/rust-skia/) and all his help and making the favor of hosting prebuilt binaries of skia for the combo of features use by Freya.
+- [geom3trik](https://github.com/geom3trik) for helping me figure out how to add incremental rendering.
+- [Tropical](https://github.com/Tropix126) for this contributions to improving accessibility and rendering.
+- And to the rest of contributors and anybody who gave me any kind of feedback!
+
 ### 🤠 Projects
 
 [Valin](https://github.com/marc2332/valin) ⚒️ is a Work-In-Progress cross-platform code editor, made with Freya 🦀 and Rust, by me.

crates/components/src/activable_route.rs

@@ -5,7 +5,29 @@ use dioxus_router::{
 };
 use freya_hooks::ActivableRouteContext;
 
-/// Provide a context to the inner components so they can know whether the passed route is the current router in the Router or not.
+/// Sometimes you might want to know if a route is selected so you can style a specific UI element in a different way,
+/// like a button with a different color.
+/// To avoid cluttering your components with router-specific code you might instead want to wrap your component in an `ActivableRoute`
+/// and inside your component call `use_activable_route`.
+///
+/// This way, your component and all its desdendants will just know whether a route is activated or not, but not which one.
+///
+/// ```rs
+/// Link {
+///     to: Route::Home, // Direction route
+///     ActivableRoute {
+///         route: Route::Home, // Activation route
+///         SidebarItem {
+///             // `SidebarItem` will now appear "activated" when the route is `Route::Home`
+///             // `ActivableRoute` is letting it know whether `Route::Home` is enabled
+///             // or not, without the need to add router-specific logic in `SidebarItem`.
+///             label {
+///                 "Go to Hey ! 👋"
+///             }
+///         },
+///     }
+/// }
+/// ```
 #[allow(non_snake_case)]
 #[component]
 pub fn ActivableRoute<T: Clone + PartialEq + Routable + 'static>(

crates/components/src/button.rs

@@ -274,6 +274,7 @@ pub fn ButtonBase(
             corner_radius: "{corner_radius}",
             background: "{background}",
             text_align: "center",
+            text_height: "disable-least-ascent",
             main_align: "center",
             cross_align: "center",
             {&children}

crates/components/src/progress_bar.rs

@@ -76,6 +76,7 @@ pub fn ProgressBar(
                             width: "100%",
                             color: "{color}",
                             max_lines: "1",
+                            text_height: "disable-least-ascent",
                             "{progress.floor()}%"
                         }
                     }

crates/components/src/scroll_views/scroll_view.rs

@@ -159,10 +159,16 @@ pub fn ScrollView(
 
     let direction_is_vertical = direction == "vertical";
 
-    let vertical_scrollbar_is_visible =
-        is_scrollbar_visible(show_scrollbar, size.inner.height, size.area.height());
-    let horizontal_scrollbar_is_visible =
-        is_scrollbar_visible(show_scrollbar, size.inner.width, size.area.width());
+    let vertical_scrollbar_is_visible = is_scrollbar_visible(
+        show_scrollbar,
+        size.inner.height.floor(),
+        size.area.height().floor(),
+    );
+    let horizontal_scrollbar_is_visible = is_scrollbar_visible(
+        show_scrollbar,
+        size.inner.width.floor(),
+        size.area.width().floor(),
+    );
 
     let (container_width, content_width) = get_container_size(
         &width,

crates/components/src/tile.rs

@@ -43,8 +43,6 @@ pub fn Tile(
     onselect: Option<EventHandler<()>>,
     /// Theme override.
     theme: Option<TileThemeWith>,
-
-    a11y_name: Option<String>,
 ) -> Element {
     let mut status = use_signal(TileStatus::default);
     let platform = use_platform();

crates/core/src/layout.rs

@@ -35,22 +35,23 @@ pub fn process_layout(
         let mut compositor_dirty_area = fdom.compositor_dirty_area();
         let mut buffer = layout.dirty.iter().copied().collect_vec();
         while let Some(node_id) = buffer.pop() {
-            if let Some(area) = Compositor::get_drawing_area(node_id, &layout, rdom, scale_factor) {
-                // Unite the invalidated area with the dirty area
-                compositor_dirty_area.unite_or_insert(&area);
+            if let Some(node) = rdom.get(node_id) {
+                if let Some(area) =
+                    Compositor::get_drawing_area(node_id, &layout, rdom, scale_factor)
+                {
+                    // Unite the invalidated area with the dirty area
+                    compositor_dirty_area.unite_or_insert(&area);
 
-                // Mark these elements as dirty for the compositor
-                compositor_dirty_nodes.insert(node_id);
+                    // Mark these elements as dirty for the compositor
+                    compositor_dirty_nodes.insert(node_id);
 
-                // Continue iterating in the children of this node
-                if let Some(node) = rdom.get(node_id) {
                     // Mark as invalidated this node as its layout has changed
                     if node.get_accessibility_id().is_some() {
                         dirty_accessibility_tree.add_or_update(node_id);
                     }
-
-                    buffer.extend(node.child_ids());
                 }
+                // Continue iterating in the children of this node
+                buffer.extend(node.child_ids());
             }
         }
         let root_id = fdom.rdom().root_id();

crates/core/src/render/compositor.rs

@@ -257,7 +257,7 @@ mod test {
     use itertools::sorted;
 
     fn run_compositor(
-        utils: &TestingHandler,
+        utils: &TestingHandler<()>,
         compositor: &mut Compositor,
     ) -> (Layers, Layers, usize) {
         let sdom = utils.sdom();

crates/core/src/render/utils/label.rs

@@ -21,12 +21,14 @@ pub fn create_label(
     paragraph_style.set_text_align(font_style.text_align);
     paragraph_style.set_max_lines(font_style.max_lines);
     paragraph_style.set_replace_tab_characters(true);
+    paragraph_style.set_text_height_behavior(font_style.text_height);
 
     if let Some(ellipsis) = font_style.text_overflow.get_ellipsis() {
         paragraph_style.set_ellipsis(ellipsis);
     }
 
-    let text_style = font_style.text_style(default_font_family, scale_factor);
+    let text_style =
+        font_style.text_style(default_font_family, scale_factor, font_style.text_height);
     paragraph_style.set_text_style(&text_style);
 
     let mut paragraph_builder = ParagraphBuilder::new(&paragraph_style, font_collection);

crates/core/src/render/utils/paragraph.rs

@@ -34,14 +34,16 @@ pub fn create_paragraph(
     paragraph_style.set_text_align(font_style.text_align);
     paragraph_style.set_max_lines(font_style.max_lines);
     paragraph_style.set_replace_tab_characters(true);
+    paragraph_style.set_text_height_behavior(font_style.text_height);
 
     if let Some(ellipsis) = font_style.text_overflow.get_ellipsis() {
         paragraph_style.set_ellipsis(ellipsis);
     }
 
     let mut paragraph_builder = ParagraphBuilder::new(&paragraph_style, font_collection);
 
-    let text_style = font_style.text_style(default_font_family, scale_factor);
+    let text_style =
+        font_style.text_style(default_font_family, scale_factor, font_style.text_height);
     paragraph_builder.push_style(&text_style);
 
     for text_span in node.children() {
@@ -52,8 +54,12 @@ pub fn create_paragraph(
             let text_nodes = text_span.children();
             let text_node = *text_nodes.first().unwrap();
             let text_node_type = &*text_node.node_type();
-            let font_style = text_span.get::<FontStyleState>().unwrap();
-            let text_style = font_style.text_style(default_font_family, scale_factor);
+            let text_font_style = text_span.get::<FontStyleState>().unwrap();
+            let text_style = text_font_style.text_style(
+                default_font_family,
+                scale_factor,
+                font_style.text_height,
+            );
             paragraph_builder.push_style(&text_style);
 
             if let NodeType::Text(text) = text_node_type {

crates/elements/src/_docs/attributes/text_height.md

@@ -0,0 +1,22 @@
+Specify the text height behavior.
+
+Accepted values:
+
+- `disable-all` (default)
+- `all`
+- `disable-first-ascent`
+- `disable-least-ascent`
+
+### Example
+
+```rust, no_run
+# use freya::prelude::*;
+fn app() -> Element {
+    rsx!(
+        label {
+            text_height: "disable-all",
+            "Hello, World!"
+        }
+    )
+}
+```