Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add custom SendAnyMap for torin to not depend on freya-native-core #1038

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 9, 2025

Also put NoopMeasurer in torin.

@marc2332 marc2332 added enhancement 🔥 New feature or request fix 🩹 Fixes a bug labels Jan 9, 2025
@marc2332 marc2332 added this to the 0.3.0 milestone Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Benchmark for bc3dcca

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.5±0.77ms 104.7±1.22ms -0.76%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 22.9±0.29ms 23.7±0.82ms +3.49%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1391.6±8.65µs 1395.0±90.67µs +0.24%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 133.1±2.83µs 133.7±3.16µs +0.45%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.4±0.27ms 23.1±0.41ms -1.28%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1715.9±47.04µs 1700.2±38.98µs -0.91%
benchmarks/size=19531 depth=7 wide=5 mode=cached 312.4±3.41µs 314.2±2.76µs +0.58%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.6±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 415.5±161.77µs 413.7±152.50µs -0.43%
benchmarks/size=54241 depth=5 wide=15 mode=cached 242.7±6.88µs 249.0±13.68µs +2.60%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.04ms 6.3±0.08ms 0.00%

Copy link

github-actions bot commented Jan 9, 2025

Benchmark for 4c0922f

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.0±1.20ms 106.3±0.83ms -0.65%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.7±1.03ms 25.7±1.25ms +4.05%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1386.9±44.20µs 1385.8±16.43µs -0.08%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 136.1±12.85µs 134.6±1.12µs -1.10%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.4±0.34ms 24.1±0.45ms -1.23%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1730.7±12.20µs 1683.1±14.55µs -2.75%
benchmarks/size=19531 depth=7 wide=5 mode=cached 368.2±38.18µs 318.7±12.97µs -13.44%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.10ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 417.9±180.93µs 413.3±86.34µs -1.10%
benchmarks/size=54241 depth=5 wide=15 mode=cached 256.9±17.39µs 254.4±15.12µs -0.97%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.17ms 6.4±0.18ms +1.59%

Copy link

github-actions bot commented Jan 9, 2025

Benchmark for 47cbd05

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.5±1.07ms 108.7±1.38ms +1.12%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 27.5±0.53ms 25.6±1.17ms -6.91%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1399.0±15.84µs 1386.7±15.39µs -0.88%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.1±1.60µs 133.6±2.17µs -1.11%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.6±0.93ms 26.7±0.42ms +4.30%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.0±0.18ms 1923.6±173.65µs -3.82%
benchmarks/size=19531 depth=7 wide=5 mode=cached 328.4±17.79µs 379.0±42.16µs +15.41%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.03ms 2.9±0.23ms +11.54%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 412.0±48.95µs 420.5±181.68µs +2.06%
benchmarks/size=54241 depth=5 wide=15 mode=cached 305.9±50.65µs 303.6±47.11µs -0.75%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.22ms 6.9±0.31ms +7.81%

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.83%. Comparing base (066c1ea) to head (a31dbaa).

Files with missing lines Patch % Lines
crates/torin/src/custom_measurer.rs 0.00% 11 Missing ⚠️
crates/torin/src/sendanymap.rs 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   74.87%   74.83%   -0.04%     
==========================================
  Files         219      220       +1     
  Lines       25675    25690      +15     
==========================================
+ Hits        19223    19226       +3     
- Misses       6452     6464      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request fix 🩹 Fixes a bug
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant