Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve and optimize elements clipping #353

Merged
merged 31 commits into from
Oct 26, 2023

Conversation

marc2332
Copy link
Owner

Depends on #330

@marc2332 marc2332 added enhancement 🔥 New feature or request performance ⚡️ Performance improvement ⚡️ labels Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (13d83b9) 51.86% compared to head (b2ae311) 53.50%.
Report is 1 commits behind head on main.

❗ Current head b2ae311 differs from pull request most recent head fe81183. Consider uploading reports for the commit fe81183 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   51.86%   53.50%   +1.64%     
==========================================
  Files         131      133       +2     
  Lines       11535    11968     +433     
==========================================
+ Hits         5983     6404     +421     
- Misses       5552     5564      +12     
Files Coverage Δ
crates/components/src/external_link.rs 0.00% <ø> (ø)
crates/components/src/switch.rs 0.00% <ø> (ø)
crates/components/src/table.rs 0.00% <ø> (ø)
crates/core/src/viewports.rs 95.34% <100.00%> (-2.02%) ⬇️
crates/devtools/src/tabs/layout.rs 0.00% <ø> (ø)
crates/dom/src/dom_adapter.rs 54.54% <100.00%> (+0.32%) ⬆️
crates/elements/src/elements.rs 26.66% <ø> (ø)
crates/hooks/src/use_theme.rs 0.00% <ø> (ø)
crates/state/tests/parse_display.rs 100.00% <100.00%> (ø)
crates/testing/tests/test.rs 100.00% <ø> (ø)
... and 22 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as draft October 23, 2023 06:42
Base automatically changed from feat/enhanced-alignments to main October 26, 2023 21:07
@marc2332 marc2332 marked this pull request as ready for review October 26, 2023 21:08
@marc2332 marc2332 merged commit 26fcb54 into main Oct 26, 2023
6 checks passed
@marc2332 marc2332 deleted the feat/improve-and-optimize-elements-clipping branch October 26, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request performance ⚡️ Performance improvement ⚡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant