Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scroll controller #367

Closed
wants to merge 4 commits into from
Closed

feat: Scroll controller #367

wants to merge 4 commits into from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Nov 4, 2023

Blocked by DioxusLabs/dioxus#1609
Depends on #366
Closes #59

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (536e9e3) 53.36% compared to head (ec5984e) 53.09%.

Additional details and impacted files
@@                           Coverage Diff                            @@
##           feat/devtools-fixes-and-improvements     #367      +/-   ##
========================================================================
- Coverage                                 53.36%   53.09%   -0.28%     
========================================================================
  Files                                       133      134       +1     
  Lines                                     12127    12190      +63     
========================================================================
  Hits                                       6472     6472              
- Misses                                     5655     5718      +63     
Files Coverage Δ
crates/devtools/src/lib.rs 0.00% <0.00%> (ø)
crates/devtools/src/tabs/tree.rs 0.00% <0.00%> (ø)
crates/components/src/input.rs 0.00% <0.00%> (ø)
...components/src/scroll_views/virtual_scroll_view.rs 0.00% <0.00%> (ø)
crates/hooks/src/use_scroll_controller.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/devtools-fixes-and-improvements to main November 11, 2023 16:10
@marc2332 marc2332 added this to the 0.2.0 milestone Nov 13, 2023
@marc2332
Copy link
Owner Author

I need to get this under #346

@marc2332 marc2332 removed the blocked label Feb 12, 2024
@marc2332 marc2332 removed this from the 0.2.0 milestone Apr 29, 2024
@marc2332
Copy link
Owner Author

marc2332 commented Jun 8, 2024

Closing for now as it just needs to be done again properly

@marc2332 marc2332 closed this Jun 8, 2024
@marc2332 marc2332 deleted the feat/scroll-controller branch July 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: Controlled scrolling
1 participant