Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Organize torin tests #369

Merged
merged 2 commits into from
Nov 11, 2023
Merged

chore: Organize torin tests #369

merged 2 commits into from
Nov 11, 2023

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Nov 4, 2023

Closes #363

Copy link

github-actions bot commented Nov 4, 2023

Benchmark for 3a1fcf7

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + branches + cached) + invalidated node in the middle 1461.4±641.82µs 1148.8±220.02µs -21.39%
benchmarks/big trees (deep + cached) + invalidated node in the bottom 130.5±22.51µs 134.7±71.30µs +3.22%
benchmarks/big trees (deep + cached) + invalidated node in the middle 154.1±41.44µs 155.2±67.54µs +0.71%
benchmarks/big trees (deep + cached) + invalidated node in the top 250.0±82.91µs 245.0±24.43µs -2.00%
benchmarks/big trees (deep) nodes=10000, depth=14 306.3±48.25µs 322.5±79.91µs +5.29%
benchmarks/big trees (deep) nodes=100000, depth=17 5.1±0.74ms 5.3±0.88ms +3.92%
benchmarks/big trees (deep) nodes=4000, depth=12 148.1±24.53µs 152.1±17.32µs +2.70%
benchmarks/big trees (wide) nodes=1000, depth=1 241.6±24.91µs 266.2±41.92µs +10.18%
benchmarks/big trees (wide) nodes=10000, depth=1 2.5±0.26ms 2.6±0.26ms +4.00%
benchmarks/big trees (wide) nodes=100000, depth=1 46.3±2.74ms 48.4±3.05ms +4.54%

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (205b7f2) 53.61% compared to head (7db5f05) 53.60%.
Report is 3 commits behind head on main.

❗ Current head 7db5f05 differs from pull request most recent head ff03120. Consider uploading reports for the commit ff03120 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   53.61%   53.60%   -0.01%     
==========================================
  Files         133      138       +5     
  Lines       12072    12071       -1     
==========================================
- Hits         6472     6471       -1     
  Misses       5600     5600              
Files Coverage Δ
crates/torin/tests/alignment.rs 100.00% <100.00%> (ø)
crates/torin/tests/margin.rs 100.00% <100.00%> (ø)
crates/torin/tests/other.rs 100.00% <100.00%> (ø)
crates/torin/tests/padding.rs 100.00% <100.00%> (ø)
crates/torin/tests/size.rs 100.00% <100.00%> (ø)
crates/torin/src/test_utils.rs 96.36% <96.36%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 mentioned this pull request Nov 5, 2023
3 tasks
@marc2332 marc2332 marked this pull request as ready for review November 11, 2023 16:11
Copy link

Benchmark for bfcfc66

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + branches + cached) + invalidated node in the middle 886.4±67.88µs 900.2±85.35µs +1.56%
benchmarks/big trees (deep + cached) + invalidated node in the bottom 86.0±70.15µs 85.1±57.15µs -1.05%
benchmarks/big trees (deep + cached) + invalidated node in the middle 96.5±1.87µs 98.9±60.64µs +2.49%
benchmarks/big trees (deep + cached) + invalidated node in the top 152.4±1.99µs 152.3±1.43µs -0.07%
benchmarks/big trees (deep) nodes=10000, depth=14 205.0±8.32µs 214.5±14.78µs +4.63%
benchmarks/big trees (deep) nodes=100000, depth=17 3.3±0.06ms 3.4±0.10ms +3.03%
benchmarks/big trees (deep) nodes=4000, depth=12 100.9±2.27µs 104.1±2.21µs +3.17%
benchmarks/big trees (wide) nodes=1000, depth=1 152.8±3.74µs 165.1±2.46µs +8.05%
benchmarks/big trees (wide) nodes=10000, depth=1 2.0±0.02ms 2.1±0.02ms +5.00%
benchmarks/big trees (wide) nodes=100000, depth=1 29.5±0.31ms 31.5±0.49ms +6.78%

@marc2332 marc2332 merged commit cccc754 into main Nov 11, 2023
10 checks passed
@marc2332 marc2332 deleted the chore/organize-torin-tests branch November 11, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Split torin's tests into multiple files by category
1 participant