-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rethink parsing #785
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 75.99% 75.82% -0.18%
==========================================
Files 207 208 +1
Lines 23775 23793 +18
==========================================
- Hits 18067 18040 -27
- Misses 5708 5753 +45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having to write
let mut parser = Parser::new(Lexer::parse(value));
every time in the node states is a step back, why aren't those using parse_value
?
I forgot to change the node states code when I added the |
replace all Parser::new(...) in node states with Parse::parse_value
…g' into feat/rethink-parsing
@marc2332 done |
chore: change parsing api chore: change color parsing
Can you make sure that all the examples run just fine @Aiving ? |
You may do this by running the |
Co-authored-by: Marc Espin <[email protected]>
oki, i'll try |
Conflicts @Aiving |
resolved! |
We need to make sure no example broke |
No description provided.