Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spacing attribute #834

Merged
merged 4 commits into from
Sep 3, 2024
Merged

feat: spacing attribute #834

merged 4 commits into from
Sep 3, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Aug 31, 2024

Closes #829

@marc2332 marc2332 added enhancement 🔥 New feature or request layout 📐 Relate to layout labels Aug 31, 2024
Copy link

Benchmark for 7674a22

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.6±0.66ms 104.6±1.23ms -2.79%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.2±1.08ms 25.9±1.44ms +2.78%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1471.8±160.36µs 1415.4±87.58µs -3.83%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 136.1±1.88µs 135.9±1.35µs -0.15%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.6±1.07ms 25.1±1.03ms +2.03%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1755.2±91.72µs 1766.2±140.28µs +0.63%
benchmarks/size=19531 depth=7 wide=5 mode=cached 347.4±49.41µs 343.1±33.18µs -1.24%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.38ms 2.7±0.22ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 411.0±58.07µs 413.9±79.92µs +0.71%
benchmarks/size=54241 depth=5 wide=15 mode=cached 292.0±97.38µs 313.0±177.86µs +7.19%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.6±0.58ms 6.7±0.58ms +1.52%

Copy link

Benchmark for 439bd3e

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 97.4±0.63ms 95.1±1.46ms -2.36%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 22.1±0.39ms 22.7±1.10ms +2.71%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1322.3±20.74µs 1309.3±34.55µs -0.98%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 126.5±1.94µs 127.4±3.08µs +0.71%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 22.0±0.19ms 22.0±0.24ms 0.00%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1558.5±30.01µs 1558.6±28.97µs +0.01%
benchmarks/size=19531 depth=7 wide=5 mode=cached 288.5±5.58µs 288.4±3.61µs -0.03%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.4±0.02ms 2.4±0.02ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 385.7±133.47µs 380.2±90.63µs -1.43%
benchmarks/size=54241 depth=5 wide=15 mode=cached 233.3±10.49µs 228.9±8.29µs -1.89%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 5.9±0.06ms 5.9±0.07ms 0.00%

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 99.22481% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.76%. Comparing base (f8a0844) to head (7263ecf).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/state/src/layout.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   73.62%   73.76%   +0.13%     
==========================================
  Files         200      201       +1     
  Lines       21543    21661     +118     
==========================================
+ Hits        15862    15978     +116     
- Misses       5681     5683       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark for 3dac6c0

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.1±0.88ms 103.3±0.64ms -2.64%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 26.3±0.94ms 25.8±1.33ms -1.90%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1465.6±17.77µs 1413.5±48.22µs -3.55%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 141.4±5.60µs 136.0±1.12µs -3.82%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.1±0.58ms 24.7±0.64ms +2.49%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1675.4±12.14µs 1781.3±15.73µs +6.32%
benchmarks/size=19531 depth=7 wide=5 mode=cached 319.1±4.57µs 322.4±23.44µs +1.03%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.05ms 2.6±0.04ms -3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 417.0±134.14µs 414.0±74.95µs -0.72%
benchmarks/size=54241 depth=5 wide=15 mode=cached 291.6±47.01µs 268.6±49.36µs -7.89%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.06ms 6.5±0.21ms +1.56%

@marc2332 marc2332 mentioned this pull request Sep 1, 2024
@marc2332 marc2332 merged commit 82eb8a0 into main Sep 3, 2024
5 checks passed
@marc2332 marc2332 deleted the feat/spacing-attribute branch September 3, 2024 12:39
Copy link

github-actions bot commented Sep 3, 2024

Benchmark for 9033e54

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 102.2±0.91ms 102.1±0.15ms -0.10%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.5±0.30ms 23.8±1.06ms +1.28%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1405.0±17.59µs 1405.5±30.65µs +0.04%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.6±0.91µs 135.4±0.84µs +0.59%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.0±0.23ms 22.9±0.19ms -0.43%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1692.3±69.38µs 1671.1±3.65µs -1.25%
benchmarks/size=19531 depth=7 wide=5 mode=cached 310.4±1.29µs 309.7±3.12µs -0.23%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.16ms 2.6±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 413.2±149.79µs 411.8±102.16µs -0.34%
benchmarks/size=54241 depth=5 wide=15 mode=cached 248.8±106.38µs 254.7±163.04µs +2.37%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.03ms 6.7±0.16ms +6.35%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request layout 📐 Relate to layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: spacing attribute for rect
1 participant