-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Physical pixel snapping #837
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 76.04% 75.92% -0.12%
==========================================
Files 205 205
Lines 23235 23290 +55
==========================================
+ Hits 17670 17684 +14
- Misses 5565 5606 +41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The switch animation looks weird now, and I don't think disabling the rounding just for the switch is a good solution either.
Any suggestions on what I should do here instead? I'll look into the switch animation. |
Hmm... Okay try now, I think it should be fixed on switch. |
This is a rewrite of #245 that's up to date. Same deal - it just rounds all elements to render on physical pixel boundaries rather than relying subpixel antialiasing which results in blurry borders or incorrect rendering in the case of #836.